Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance - azurerm_api_management_api - support contact, license #18472

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

xuzhang3
Copy link
Contributor

Support config contact, license, terms_of_service_url

=== RUN   TestAccApiManagementApi_basic
=== PAUSE TestAccApiManagementApi_basic
=== RUN   TestAccApiManagementApi_wordRevision
=== PAUSE TestAccApiManagementApi_wordRevision
=== RUN   TestAccApiManagementApi_blankPath
=== PAUSE TestAccApiManagementApi_blankPath
=== RUN   TestAccApiManagementApi_version
=== PAUSE TestAccApiManagementApi_version
=== RUN   TestAccApiManagementApi_oauth2Authorization
=== PAUSE TestAccApiManagementApi_oauth2Authorization
=== RUN   TestAccApiManagementApi_openidAuthentication
=== PAUSE TestAccApiManagementApi_openidAuthentication
=== RUN   TestAccApiManagementApi_requiresImport
=== PAUSE TestAccApiManagementApi_requiresImport
=== RUN   TestAccApiManagementApi_graphql
=== PAUSE TestAccApiManagementApi_graphql
=== RUN   TestAccApiManagementApi_soap
=== PAUSE TestAccApiManagementApi_soap
=== RUN   TestAccApiManagementApi_websocket
=== PAUSE TestAccApiManagementApi_websocket
=== RUN   TestAccApiManagementApi_soapPassthrough
=== PAUSE TestAccApiManagementApi_soapPassthrough
=== RUN   TestAccApiManagementApi_subscriptionRequired
=== PAUSE TestAccApiManagementApi_subscriptionRequired
=== RUN   TestAccApiManagementApi_importSwagger
=== PAUSE TestAccApiManagementApi_importSwagger
=== RUN   TestAccApiManagementApi_importWsdl
=== PAUSE TestAccApiManagementApi_importWsdl
=== RUN   TestAccApiManagementApi_importUpdate
=== PAUSE TestAccApiManagementApi_importUpdate
=== RUN   TestAccApiManagementApi_complete
=== PAUSE TestAccApiManagementApi_complete
=== RUN   TestAccApiManagementApi_cloneApi
=== PAUSE TestAccApiManagementApi_cloneApi
=== RUN   TestAccApiManagementApi_createNewVersionFromExisting
=== PAUSE TestAccApiManagementApi_createNewVersionFromExisting
=== RUN   TestAccApiManagementApi_createRevisionFromExisting
=== PAUSE TestAccApiManagementApi_createRevisionFromExisting
=== RUN   TestAccApiManagementApi_createRevisionFromExistingRevision
=== PAUSE TestAccApiManagementApi_createRevisionFromExistingRevision
=== RUN   TestAccApiManagementApi_contact
=== PAUSE TestAccApiManagementApi_contact
=== CONT  TestAccApiManagementApi_basic
=== CONT  TestAccApiManagementApi_subscriptionRequired
=== CONT  TestAccApiManagementApi_cloneApi
=== CONT  TestAccApiManagementApi_importUpdate
=== CONT  TestAccApiManagementApi_complete
=== CONT  TestAccApiManagementApi_importWsdl
=== CONT  TestAccApiManagementApi_importSwagger
=== CONT  TestAccApiManagementApi_createRevisionFromExisting
--- PASS: TestAccApiManagementApi_basic (542.01s)
=== CONT  TestAccApiManagementApi_createNewVersionFromExisting
--- PASS: TestAccApiManagementApi_cloneApi (549.29s)
=== CONT  TestAccApiManagementApi_contact
--- PASS: TestAccApiManagementApi_importWsdl (549.36s)
=== CONT  TestAccApiManagementApi_requiresImport
--- PASS: TestAccApiManagementApi_importSwagger (550.12s)
=== CONT  TestAccApiManagementApi_soapPassthrough
--- PASS: TestAccApiManagementApi_subscriptionRequired (550.60s)
=== CONT  TestAccApiManagementApi_websocket
--- PASS: TestAccApiManagementApi_createRevisionFromExisting (551.19s)
=== CONT  TestAccApiManagementApi_soap
--- PASS: TestAccApiManagementApi_complete (564.15s)
=== CONT  TestAccApiManagementApi_graphql
--- PASS: TestAccApiManagementApi_importUpdate (678.92s)
=== CONT  TestAccApiManagementApi_version
--- PASS: TestAccApiManagementApi_contact (518.18s)
=== CONT  TestAccApiManagementApi_openidAuthentication
--- PASS: TestAccApiManagementApi_soapPassthrough (520.43s)
=== CONT  TestAccApiManagementApi_oauth2Authorization
--- PASS: TestAccApiManagementApi_soap (525.18s)
=== CONT  TestAccApiManagementApi_blankPath
--- PASS: TestAccApiManagementApi_createNewVersionFromExisting (540.40s)
=== CONT  TestAccApiManagementApi_wordRevision
--- PASS: TestAccApiManagementApi_graphql (523.62s)
=== CONT  TestAccApiManagementApi_createRevisionFromExistingRevision
--- PASS: TestAccApiManagementApi_requiresImport (564.24s)
--- PASS: TestAccApiManagementApi_version (537.72s)
--- PASS: TestAccApiManagementApi_blankPath (435.38s)
--- PASS: TestAccApiManagementApi_wordRevision (502.94s)
--- PASS: TestAccApiManagementApi_oauth2Authorization (520.85s)
--- PASS: TestAccApiManagementApi_openidAuthentication (531.33s)
--- PASS: TestAccApiManagementApi_createRevisionFromExistingRevision (534.59s)
--- PASS: TestAccApiManagementApi_websocket (5274.84s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/apimanagement 5876.199s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have some test failures:

------- Stdout: -------
=== RUN   TestAccApiManagementApiTagDescription_basic
=== PAUSE TestAccApiManagementApiTagDescription_basic
=== CONT  TestAccApiManagementApiTagDescription_basic
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Api Tag Descriptions: (Tag Description Name "acctest-Tag-220922142415133918" / Api Name "acctestapi-220922142415133918" / Service Name "acctestAM-220922142415133918" / Resource Group "acctestRG-220922142415133918"): apimanagement.APITagDescriptionClient#Delete: Failure responding to request: StatusCode=412 -- Original Error: autorest/azure: Service returned an error. Status=412 Code="PreconditionFailed" Message="Exception of type 'Microsoft.WindowsAzure.ApiManagement.Management.Core.Exceptions.PreconditionFailedException' was thrown."
        
--- FAIL: TestAccApiManagementApiTagDescription_basic (216.48s)
FAIL

@xuzhang3
Copy link
Contributor Author

have some test failures:

------- Stdout: -------
=== RUN   TestAccApiManagementApiTagDescription_basic
=== PAUSE TestAccApiManagementApiTagDescription_basic
=== CONT  TestAccApiManagementApiTagDescription_basic
    testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Api Tag Descriptions: (Tag Description Name "acctest-Tag-220922142415133918" / Api Name "acctestapi-220922142415133918" / Service Name "acctestAM-220922142415133918" / Resource Group "acctestRG-220922142415133918"): apimanagement.APITagDescriptionClient#Delete: Failure responding to request: StatusCode=412 -- Original Error: autorest/azure: Service returned an error. Status=412 Code="PreconditionFailed" Message="Exception of type 'Microsoft.WindowsAzure.ApiManagement.Management.Core.Exceptions.PreconditionFailedException' was thrown."
        
--- FAIL: TestAccApiManagementApiTagDescription_basic (216.48s)
FAIL

Cannot reproduce this error.

=== RUN   TestAccApiManagementApiTagDescription_basic
=== PAUSE TestAccApiManagementApiTagDescription_basic
=== CONT  TestAccApiManagementApiTagDescription_basic
--- PASS: TestAccApiManagementApiTagDescription_basic (689.95s)
PASS

@katbyte
Copy link
Collaborator

katbyte commented Sep 24, 2022

test failures still:
image

@xuzhang3
Copy link
Contributor Author

@katbyte rerun the accTest a few times, all passed.
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM 🦺

@katbyte katbyte merged commit 3c3d494 into hashicorp:main Oct 12, 2022
katbyte added a commit that referenced this pull request Oct 12, 2022
@github-actions github-actions bot added this to the v3.27.0 milestone Oct 12, 2022
@github-actions
Copy link

This functionality has been released in v3.27.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
@xuzhang3 xuzhang3 deleted the f/apim_api_enhance branch August 14, 2024 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants