Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/kubernetes_cluster: Fix missing forceNew on service principal fields #1737

Merged

Conversation

lawrencegripper
Copy link
Contributor

@lawrencegripper lawrencegripper commented Aug 8, 2018

Repro using the current provider:

  1. Create a cluster
  2. Change the Service Principal used
  3. See error:
  • azurerm_kubernetes_cluster.aks: containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="PropertyChangeNotAllowed" Message="Changing property 'servicePrincipalProfile.clientId' is not allowed." Target="servicePrincipalProfile.clientId"

This PR moves the SP properties to ForceNew to fix this issue and force a new cluster when changes are made.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this 👍

@tombuildsstuff tombuildsstuff added this to the 1.13.0 milestone Aug 8, 2018
@tombuildsstuff tombuildsstuff merged commit 38c56b2 into hashicorp:master Aug 8, 2018
tombuildsstuff added a commit that referenced this pull request Aug 8, 2018
@tombuildsstuff
Copy link
Contributor

hey @lawrencegripper

Just to let you know that we've just shipped support for this as a part of v1.13.0 of the AzureRM Provider :)

Thanks!

},

"client_secret": {
Type: schema.TypeString,
ForceNew: true,
Copy link
Contributor

@hazzik hazzik Sep 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not have any effect because the client_secret is not retrieved from the environment nor stored in a state file.

@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants