Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_express_route_gateway - Handle gateway connections not found error #16804

Merged
merged 1 commit into from
May 16, 2022

Conversation

xuzhang3
Copy link
Contributor

This PR is trying to fix a bug introduced by PR #16680. Create new ER Gateway will try to get the connections before creating it, service returns a 404 error if the Gateway does not exist.

=== RUN   TestAccExpressRouteGateway_basic
=== PAUSE TestAccExpressRouteGateway_basic
=== RUN   TestAccExpressRouteGateway_requiresImport
=== PAUSE TestAccExpressRouteGateway_requiresImport
=== RUN   TestAccExpressRouteGateway_update
=== PAUSE TestAccExpressRouteGateway_update
=== CONT  TestAccExpressRouteGateway_requiresImport
=== CONT  TestAccExpressRouteGateway_basic
=== CONT  TestAccExpressRouteGateway_update
--- PASS: TestAccExpressRouteGateway_requiresImport (3890.65s)
--- PASS: TestAccExpressRouteGateway_basic (4006.44s)
--- PASS: TestAccExpressRouteGateway_update (6184.30s)
PASS
PASS    github.com/hashicorp/terraform-provider-azurerm/internal/services/network       6186.389s

Signed-off-by: Zooopx <xuzhang3@microsoft.com>
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v3.7.0 milestone May 16, 2022
@mbfrahry mbfrahry changed the title [Bug fix] azurerm_express_route_gateway - Handle gateway connections get error azurerm_express_route_gateway - Handle gateway connections not found error May 16, 2022
@mbfrahry mbfrahry merged commit 0e1e742 into hashicorp:main May 16, 2022
mbfrahry added a commit that referenced this pull request May 16, 2022
@github-actions
Copy link

This functionality has been released in v3.7.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
@xuzhang3 xuzhang3 deleted the fix/er_gateway_create branch August 14, 2024 02:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants