Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting owner and group property on azurerm_storage_data_lake_gen2_filesystem #15547

Closed
LoW0lf opened this issue Feb 22, 2022 · 4 comments · Fixed by #15598
Closed

Comments

@LoW0lf
Copy link

LoW0lf commented Feb 22, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In order to properly configure the owning user and owner group (ACL) on a datalake root folder we should have the possibility to configure an AAD object ID for owner and group on the azurerm_storage_data_lake_gen2_filesystem resource analogue to the azurerm_storage_data_lake_gen2_path resource.

New or Affected Resource(s)

  • azurerm_storage_data_lake_gen2_filesystem

Potential Terraform Configuration

resource "azurerm_storage_data_lake_gen2_filesystem" "example" {
  name               = "example"
  storage_account_id = azurerm_storage_account.example.id
  owner = "00000000-0000-0000-0000-000000000000"
  group = "00000000-0000-0000-0000-000000000000"
  ace {
  ....
  }
}
@magodo
Copy link
Collaborator

magodo commented Feb 24, 2022

@LoW0lf Thank you for submitting this! By looking through the API reference of the data lake gen2 fs, there seems no mention about the owner/group. On the other hand, the API reference of the data lake gen2 path's UPDATE method has them defined.

Do you know how to do that via the rest API?

@LoW0lf
Copy link
Author

LoW0lf commented Feb 24, 2022

@magodo as far I understand it, this properties don't have to be set on the filesystem itself but on the "/" root directory that comes with the creation of the filesystem. In the current implementation of the filesystem resource, the ace's defined on the filesystem are deployed in the same way, see

if _, err := pathClient.SetAccessControl(ctx, storageID.Name, fileSystemName, "/", accessControlInput); err != nil {

In code mentioned, the owner and group property is set to nil but from my point of view this should be possible to set them analogue to the path resource.

@github-actions
Copy link

This functionality has been released in v2.99.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants