azurerm_virtual_machine - making admin_password optional for Linux VM's
#154
Conversation
| @@ -334,7 +334,7 @@ func resourceArmVirtualMachine() *schema.Resource { | |||
|
|
|||
| "admin_password": { | |||
| Type: schema.TypeString, | |||
| Required: true, | |||
| Optional: true, | |||
There was a problem hiding this comment.
Shouldn't we also mark this as Sensitive so it doesn't show up in the plan/apply output?
There was a problem hiding this comment.
Yes, probably - I'll update this :)
| } | ||
|
|
||
| os_profile { | ||
| computer_name = "hn%d" |
There was a problem hiding this comment.
Is there any special meaning behind the two letters hn? 😃
There was a problem hiding this comment.
copied it from the example above, but presumably hostname :)
There was a problem hiding this comment.
yes, it's hn - we kept this short as Windows host names cannot be more than 16 characters
|
Ignoring a subscription-specific test failure, the tests pass: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
As explained in #152 - it's possible to create a Linux VM using only SSH Keys - meaning the
admin_passwordfield can become optional.Fixes #152
Running the test suite now..