Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source :azurerm_linux_function_app #15009

Merged
merged 6 commits into from
Jan 21, 2022
Merged

New Data Source :azurerm_linux_function_app #15009

merged 6 commits into from
Jan 21, 2022

Conversation

catriona-m
Copy link
Member

No description provided.

mbfrahry
mbfrahry approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jackofallops
jackofallops approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catriona-m - couple of really minor items below, but otherwise LGTM 👍

internal/services/appservice/registration.go Outdated Show resolved Hide resolved
website/docs/d/linux_function_app.html.markdown Outdated Show resolved Hide resolved
@catriona-m catriona-m merged commit 5b8ee3d into main Jan 21, 2022
@catriona-m catriona-m deleted the cm/ds_linux_func branch January 21, 2022 10:46
@github-actions github-actions bot added this to the v2.94.0 milestone Jan 21, 2022
catriona-m added a commit that referenced this pull request Jan 21, 2022
@catriona-m
Update changelog for #15009
ab87558
@github-actions
Copy link

This functionality has been released in v2.94.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
documentation new-data-source service/app-service size/XL
Projects
None yet
Milestone
v2.94.0
Development

Successfully merging this pull request may close these issues.
3 participants
@catriona-m @mbfrahry @jackofallops