-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies: upgrading to v61.1.0 of github.com/Azure/azure-sdk-for-go #14828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All notification hub tests are failing with:
------- Stdout: -------
=== RUN TestAccNotificationHubNamespace_free
=== PAUSE TestAccNotificationHubNamespace_free
=== CONT TestAccNotificationHubNamespace_free
testcase.go:110: Step 1/2 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# azurerm_notification_hub_namespace.test will be updated in-place
~ resource "azurerm_notification_hub_namespace" "test" {
id = "/subscriptions/*******/resourceGroups/acctestRG-220106155358471509/providers/Microsoft.NotificationHubs/namespaces/acctestnhn-220106155358471509"
name = "acctestnhn-220106155358471509"
+ namespace_type = "NotificationHub"
tags = {
"env" = "Test"
}
# (5 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccNotificationHubNamespace_free (285.47s)
FAIL
Test started failing at main from 12/06, seems like there is a breaking change in the service, which doesn't return namespaceType any more. I've tried using REST API as well and had the same result. I've opened an issue at Azure/azure-rest-api-specs#17277 and will check with service team whether it's a bug or this property is no longer used any more. |
14b5fc0
to
fd14640
Compare
Rebased to main branch. Sdk version is upgraded to 61.0.0 by this pr |
@katbyte I opened a separate issue for notificationhub under Azure repo as commented above. And since the version 61.0 including the breaking change is already checked in, is it ok to further upgrade the version to 61.1 so that the new compute sdk version is also included? |
For reference, this issue also has been reported already: #14541 |
The Notification Hub API changes are unrelated to this SDK upgrade and tracked in #14541 / upstream in Azure/azure-rest-api-specs#17277 - so this isn't gated on that |
dismissing since the notification hub changes are unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @myc2h6o
This functionality has been released in v2.93.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Prepare for new compute sdk version 2021-08-01