Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_function_app - fix filtering of app_settings for WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING #14815

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

jackofallops
Copy link
Member

updates linux function app app_settings processing for WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING to check if these properties have been explicitly set by config, rather than generated by the provider.

Note to reviewer: WEBSITES_ENABLE_APP_SERVICE_STORAGE intentionally left as commented to preserve the TODO.

Partial fix for #14702

@jackofallops
Copy link
Member Author

Tests looking good:
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌋

@jackofallops jackofallops merged commit 2547b7f into main Jan 6, 2022
@jackofallops jackofallops deleted the b/linux-function-app-settings-bug branch January 6, 2022 17:09
jackofallops added a commit that referenced this pull request Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This functionality has been released in v2.91.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants