Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_custom_domain rename proxy property to gateway #14628

Merged
merged 6 commits into from
Jan 7, 2022

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Dec 15, 2021

Closes #4612

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from missing docs this LGTM 🏗️

@stephybun stephybun reopened this Dec 16, 2021
@github-actions github-actions bot added size/L and removed size/M labels Dec 16, 2021
@stephybun stephybun marked this pull request as ready for review January 5, 2022 07:56
@stephybun
Copy link
Member Author

Had to do a hard deprecation, now it's ready for review 🙂
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏗️

@stephybun stephybun merged commit 433d949 into main Jan 7, 2022
@stephybun stephybun deleted the f/api-mgmt-rename-proxy branch January 7, 2022 07:44
@github-actions github-actions bot added this to the v2.92.0 milestone Jan 7, 2022
stephybun added a commit that referenced this pull request Jan 7, 2022
@github-actions
Copy link

This functionality has been released in v2.92.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use term 'gateway' instead of 'proxy' for hostname_configuration in API Management
2 participants