New data sources azurerm_management_group_template_deployment, azurerm_resource_group_template_deployment, azurerm_subscription_template_deployment, azurerm_tenant_template_deployment

[sdebruyn]

Fixes #14523

Adds data sources as mentioned in the title so that you can retrieve the values of outputs of deployed templates.

[katbyte]

test failure @sdebruyn

------- Stdout: -------
=== RUN   TestAccDataSourceManagementGroupTemplateDeployment
=== PAUSE TestAccDataSourceManagementGroupTemplateDeployment
=== CONT  TestAccDataSourceManagementGroupTemplateDeployment
    testing_new_config.go:81: no "id" found in attributes
    testing_new.go:53: no "id" found in attributes
--- FAIL: TestAccDataSourceManagementGroupTemplateDeployment (136.73s)
FAIL

[sdebruyn]

sorry about that @katbyte, should be fixed now

[sdebruyn]

@katbyte @tombuildsstuff Any chance to merge this in before we get to 3.0?

[sdebruyn]

Rebased on latest main
@tombuildsstuff @katbyte Would you care to took a look please? The label says XL but most of the changes are very similar to what's already there.

[tombuildsstuff]

hey @sdebruyn

Thanks for this PR - apologies this has taken a while for us to get too.

I've taken a look through and left some comments inline, but on the whole this looks pretty good, if we can fix those up then we should be able to get this merged. From the Management Group resource whilst the API accepts both the Name and the ID - within Terraform we consistently use the ID (to avoid unintentional diff's in the responses due to escaping differences between the different API's) - so we'd need to update this to use the (UU)ID rather than the Name.

Thanks!

[sdebruyn]

@tombuildsstuff Thanks for the first review 🙌 It is now ready for re-review 😉

[tombuildsstuff]

hey @sdebruyn

Thanks for pushing those changes - apologies for the delay on the re-review here!

Taking a look through this now LGTM 👍

Thanks!

[tombuildsstuff]

Acceptance Tests look good 👍

[github-actions]

This functionality has been released in v3.11.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.