r/azurerm_xyz_policy_assignment add support for non_compliance_message

[matt-FFFFFF]

This PR:

• Adds support for Non-Compliance Messages to:
  • r/azurerm_subscription_policy_assignment
  • r/azurerm_resource_group_policy_assignment
  • r/azurerm_management_group_policy_assignment
  • r/azurerm_resource_policy_assignment
• Update policy API version to 2021-06-01-preview
• fixes Support for nonComplianceMessages in azurerm_policy_assignment #10401

Acceptance tests

Acceptance Tests for Policies

---

❯ TF_ACC=1 /usr/local/go/bin/go test -v ./internal/services/policy -run=TestAccSubscriptionPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage -timeout 30m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSubscriptionPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
=== PAUSE TestAccSubscriptionPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
=== CONT  TestAccSubscriptionPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
--- PASS: TestAccSubscriptionPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage (843.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/policy	844.474s

❯ TF_ACC=1 /usr/local/go/bin/go test -v ./internal/services/policy -run=TestAccResourcePolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage -timeout 30m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccResourcePolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
=== PAUSE TestAccResourcePolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
=== CONT  TestAccResourcePolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
--- PASS: TestAccResourcePolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage (860.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/policy	862.068s

❯ TF_ACC=1 /usr/local/go/bin/go test -v ./internal/services/policy -run=TestAccResourceGroupPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage -timeout 30m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccResourceGroupPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
=== PAUSE TestAccResourceGroupPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
=== CONT  TestAccResourceGroupPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
--- PASS: TestAccResourceGroupPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage (848.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/policy	850.804s

❯ TF_ACC=1 /usr/local/go/bin/go test -v ./internal/services/policy -run=TestAccManagementGroupPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage -timeout 30m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccManagementGroupPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
=== PAUSE TestAccManagementGroupPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
=== CONT  TestAccManagementGroupPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage
--- PASS: TestAccManagementGroupPolicyAssignment_basicWithBuiltInPolicyNonComplianceMessage (689.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/policy	690.368s

---

Acceptance Tests for Policy Sets

---

❯ TF_ACC=1 /usr/local/go/bin/go test -v ./internal/services/policy -run=TestAccSubscriptionPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage -timeout 30m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSubscriptionPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
=== PAUSE TestAccSubscriptionPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
=== CONT  TestAccSubscriptionPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
--- PASS: TestAccSubscriptionPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage (819.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/policy	820.257s

❯ TF_ACC=1 /usr/local/go/bin/go test -v ./internal/services/policy -run=TestAccResourcePolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage -timeout 30m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccResourcePolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
=== PAUSE TestAccResourcePolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
=== CONT  TestAccResourcePolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
--- PASS: TestAccResourcePolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage (1052.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/policy	1056.193s

❯ TF_ACC=1 /usr/local/go/bin/go test -v ./internal/services/policy -run=TestAccResourceGroupPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage -timeout 30m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccResourceGroupPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
=== PAUSE TestAccResourceGroupPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
=== CONT  TestAccResourceGroupPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
--- PASS: TestAccResourceGroupPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage (949.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/policy	952.996s

❯ TF_ACC=1 /usr/local/go/bin/go test -v ./internal/services/policy -run=TestAccManagementGroupPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage -timeout 30m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccManagementGroupPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
=== PAUSE TestAccManagementGroupPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
=== CONT  TestAccManagementGroupPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage
--- PASS: TestAccManagementGroupPolicyAssignment_basicWithBuiltInPolicySetNonComplianceMessage (943.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/policy	945.769s

---

The following has been done:

• Documentation updated
• Acceptance tests updated
• Linting passed

[katbyte]

Thanks @matt-FFFFFF - couple comments about the schema whilst passing through

[matt-FFFFFF]

Thanks @matt-FFFFFF - couple comments about the schema whilst passing through

Hi @katbyte,

I've implemented the changes now and the checks pass. Are you able to take another look please?

😄

[mbfrahry]

LGTM! The tests all pass and I really appreciate testing across all the policies we are touching here. Thanks @matt-FFFFFF!

[github-actions]

This functionality has been released in v2.90.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.