Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - exposing a formatted Connection String for Blob access #142

Merged
merged 3 commits into from
Jun 29, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Chatting with @radeksimko during #130 - I realised we were having to manually construct the Connection Strings for accessing Storage Accounts. This PR exposes a couple of fields with the Primary + Secondary (where appropriate) Connection Strings for Blob access to Storage Accounts.

Relevant test:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 300m -parallel 5 -run TestAccAzureRMStorageAccount_blobConnectionString
=== RUN   TestAccAzureRMStorageAccount_blobConnectionString
--- PASS: TestAccAzureRMStorageAccount_blobConnectionString (116.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	116.397s

Running the rest of the suite now

@tombuildsstuff
Copy link
Contributor Author

Tests pass:
screen shot 2017-06-28 at 16 55 44

Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 755f523 into master Jun 29, 2017
@tombuildsstuff tombuildsstuff deleted the storageaccount-connection-strings branch June 29, 2017 09:11
tombuildsstuff added a commit that referenced this pull request Jun 29, 2017
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
…ction-strings

`azurerm_storage_account` - exposing a formatted Connection String for Blob access
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants