Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing azurerm_cdn_endpoint's to be updated #134

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Conversation

tombuildsstuff
Copy link
Contributor

Fixes a bug which meant CDN Endpoints couldn't be updated - also updated the CDN tests to match the new function format

Fixes #97

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 300m -parallel 5 -run TestAccAzureRMCdn
=== RUN   TestAccAzureRMCdnEndpoint_importWithTags
--- PASS: TestAccAzureRMCdnEndpoint_importWithTags (209.73s)
=== RUN   TestAccAzureRMCdnProfile_importWithTags
--- PASS: TestAccAzureRMCdnProfile_importWithTags (142.53s)
=== RUN   TestAccAzureRMCdnEndpoint_basic
--- PASS: TestAccAzureRMCdnEndpoint_basic (189.55s)
=== RUN   TestAccAzureRMCdnEndpoint_disappears
--- PASS: TestAccAzureRMCdnEndpoint_disappears (331.28s)
=== RUN   TestAccAzureRMCdnEndpoint_updateHostHeader
--- PASS: TestAccAzureRMCdnEndpoint_updateHostHeader (209.12s)
=== RUN   TestAccAzureRMCdnEndpoint_withTags
--- PASS: TestAccAzureRMCdnEndpoint_withTags (197.86s)
=== RUN   TestAccAzureRMCdnProfile_basic
--- PASS: TestAccAzureRMCdnProfile_basic (129.44s)
=== RUN   TestAccAzureRMCdnProfile_withTags
--- PASS: TestAccAzureRMCdnProfile_withTags (136.37s)
=== RUN   TestAccAzureRMCdnProfile_NonStandardCasing
--- PASS: TestAccAzureRMCdnProfile_NonStandardCasing (153.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1699.375s

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 51f9347 into master Jun 27, 2017
@tombuildsstuff tombuildsstuff deleted the cdn-update branch June 27, 2017 12:43
tombuildsstuff added a commit that referenced this pull request Jun 27, 2017
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
Allowing `azurerm_cdn_endpoint`'s to be updated
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't update Azure CDN Origin Host Header
2 participants