r/kubernetes_cluster: Only setting the VnetSubnetID when it's != ""
#1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes:
```
------- Stdout: -------
=== RUN TestAccAzureRMKubernetesCluster_basic
--- FAIL: TestAccAzureRMKubernetesCluster_basic (55.13s)
testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:
* azurerm_kubernetes_cluster.test: 1 error(s) occurred:
* azurerm_kubernetes_cluster.test: containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="LinkedInvalidPropertyId" Message="Property id '' at path 'properties.agentPoolProfiles[0].vnetSubnetID' is invalid. Expect fully qualified resource Id that start with '/subscriptions/{subscriptionId}' or '/providers/{resourceProviderNamespace}/'."
FAIL
```
Passing test:
```
$ acctests azurerm TestAccAzureRMKubernetesCluster_basic
=== RUN TestAccAzureRMKubernetesCluster_basic
--- PASS: TestAccAzureRMKubernetesCluster_basic (1713.63s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 1713.661s
```
mbfrahry
approved these changes
Apr 24, 2018
|
Fixes #1160 |
|
Ignoring some AKS capacity issues - the tests pass:
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a breaking change in the Kubernetes API released recently which means the API will fail when submitting an empty string for a Subnet ID. This PR fixes this failing test, which started this morning:
Fixes:
Passing test: