Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #105 detect missing subnet properties #113

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

cchildress
Copy link
Contributor

#105

We should catch missing security group and route table entries for subnets if they're missing from the Azure API response. This sets both to an empty string in the read function if no result was returned from the Azure API.

…bnets if they're missing from the Azure API response.
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cchildress

Thanks for this PR - this LGTM and the tests pass:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -run TestAccAzureRMSubnet -timeout 300m -parallel 5
=== RUN   TestAccAzureRMSubnet_importBasic

--- PASS: TestAccAzureRMSubnet_importBasic (136.29s)
=== RUN   TestAccAzureRMSubnet_importWithRouteTable
--- PASS: TestAccAzureRMSubnet_importWithRouteTable (142.40s)
=== RUN   TestAccAzureRMSubnet_basic
--- PASS: TestAccAzureRMSubnet_basic (144.70s)
=== RUN   TestAccAzureRMSubnet_routeTableUpdate
--- PASS: TestAccAzureRMSubnet_routeTableUpdate (168.59s)
=== RUN   TestAccAzureRMSubnet_disappears
--- PASS: TestAccAzureRMSubnet_disappears (118.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	710.395s

Thanks!

@tombuildsstuff tombuildsstuff merged commit c533542 into hashicorp:master Jun 22, 2017
tombuildsstuff added a commit that referenced this pull request Jun 22, 2017
@cchildress cchildress deleted the subnet_refresh_bugfix branch June 22, 2017 15:23
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants