Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_named_location support for GPS coordinates country lookup method #1427

Closed
sdx-jkataja opened this issue Jul 3, 2024 · 0 comments · Fixed by #1589
Closed

azuread_named_location support for GPS coordinates country lookup method #1427

sdx-jkataja opened this issue Jul 3, 2024 · 0 comments · Fixed by #1589

Comments

@sdx-jkataja
Copy link
Contributor

sdx-jkataja commented Jul 3, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritise the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently any Named Location country lists created using the azuread_named_location resource with a country block have the Countries (IP) location type. On the Azure Portal this translates to Country lookup method parameter always having the Determine location by IP address setting.

Please add support for the Countries (GPS) location type. On the Azure Portal this translates to Country lookup method parameter having the Determine location by GPS coordinates option.

Concept documentation: https://learn.microsoft.com/en-us/entra/identity/conditional-access/concept-assignment-network#countries
API documentation: see countryLookupMethodType value authenticatorAppGps in https://learn.microsoft.com/en-us/graph/api/resources/countrynamedlocation?view=graph-rest-1.0#properties

New or Affected Resource(s)

Potential Terraform Configuration

Suggestion 1

resource "azuread_named_location" "example-country" {
  display_name = "Country Named Location"
  country {
    countries_and_regions = [
      "GB",
      "US",
    ]
    country_lookup_method = "GPS"
  }
}

Suggestion 2

resource "azuread_named_location" "example-country" {
  display_name = "Country Named Location"
  country {
    countries_and_regions = [
      "GB",
      "US",
    ]
    lookup_lookup_method_gps = true
  }
}

Suggestion 3

resource "azuread_named_location" "example-country" {
  display_name = "Country Named Location"
  country {
    countries_and_regions_gps_coordinates = [
      "GB",
      "US",
    ]
  }
}

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants