Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix[#1259]: remove mail nickname check #1260

Closed
wants to merge 1 commit into from

Conversation

DeviaVir
Copy link

We are already always setting a default mail nickname, the check seems to fall apart for not-yet-existing groups, but the check itself doesn't make sense since we are just setting a default if none exists.

We are already always setting a default mail nickname, the check seems
to fall apart for not-yet-existing groups, but the check itself doesn't
make sense since we are just setting a default if none exists.
@manicminer
Copy link
Contributor

@DeviaVir Thanks for suggesting this change. Unfortunately, mailNickname is a required property for mail-enabled groups as per validation in the API. When creating a security-only group, we mimic the portal behavior by generating a pseudorandom value for mailNickname, but since this property is immutable once set, we don't do the same for mail-enabled groups as this would likely defeat the intent of the group.

Screenshot 2023-11-27 at 16 35 49

If you are managing existing groups with Terraform, you will need to import the group into your statefile, and then ensure the correct properties are set in your configuration. This will include the mail_nickname property.

I appreciate the time taken to test and submit this PR, however due to the above we will unfortunately not be able to relax the validation here as it does mirror the API. If you would like to manage groups without managing the mail_nickname property, I recommend looking at the ignore_changes lifecycle meta-argument.

Accordingly, I'm going to close this PR for now. Thanks again!

@manicminer manicminer closed this Nov 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants