From f3fbd79da071408d8b0722180e299cdfe7774990 Mon Sep 17 00:00:00 2001
From: Angie Pinilla <angelinepinilla@gmail.com>
Date: Wed, 9 Dec 2020 11:15:26 -0500
Subject: [PATCH] add rule to remove extraneous string list to set casting

---
 .semgrep.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/.semgrep.yml b/.semgrep.yml
index 3520fd50fad2..46f121ee58b2 100644
--- a/.semgrep.yml
+++ b/.semgrep.yml
@@ -36,6 +36,17 @@ rules:
           regex: '^"github.com/aws/aws-sdk-go/service/[^/]+"$'
     severity: WARNING
 
+  - id: helper-schema-Set-extraneous-NewSet-with-flattenStringList
+    languages: [go]
+    message: Prefer `flattenStringSet()` function for casting a list of string pointers to a set
+    paths:
+      include:
+        - aws/
+    patterns:
+      - pattern: schema.NewSet(schema.HashString, flattenStringList($APIOBJECT))
+      - pattern-not-inside: func flattenStringSet(list []*string) *schema.Set { ... }
+    severity: WARNING
+
   - id: helper-schema-ResourceData-GetOk-with-extraneous-conditional
     languages: [go]
     message: Zero value conditional check after `d.GetOk()` is extraneous