From d33d6269502a9b1a79c953c9ec0bb3e91a3a1749 Mon Sep 17 00:00:00 2001 From: Brian Flad Date: Tue, 21 Jul 2020 00:23:46 -0400 Subject: [PATCH] resource/aws_network_acl_rule: Immediately return DescribeNetworkAcls errors on creation Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/13409 Output from acceptance testing: ``` --- PASS: TestAccAWSNetworkAclRule_allProtocol (44.33s) --- PASS: TestAccAWSNetworkAclRule_basic (32.50s) --- PASS: TestAccAWSNetworkAclRule_disappears (32.83s) --- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (27.16s) --- PASS: TestAccAWSNetworkAclRule_ingressEgressSameNumberDisappears (30.24s) --- PASS: TestAccAWSNetworkAclRule_ipv6 (29.23s) --- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (28.65s) --- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (47.71s) --- PASS: TestAccAWSNetworkAclRule_missingParam (15.14s) --- PASS: TestAccAWSNetworkAclRule_tcpProtocol (40.32s) ``` --- aws/resource_aws_network_acl_rule.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws/resource_aws_network_acl_rule.go b/aws/resource_aws_network_acl_rule.go index c8adab7a897c..52292f101e8d 100644 --- a/aws/resource_aws_network_acl_rule.go +++ b/aws/resource_aws_network_acl_rule.go @@ -198,7 +198,7 @@ func resourceAwsNetworkAclRuleCreate(d *schema.ResourceData, meta interface{}) e err = resource.Retry(3*time.Minute, func() *resource.RetryError { r, err = findNetworkAclRule(d, meta) if err != nil { - return resource.RetryableError(err) + return resource.NonRetryableError(err) } if r == nil { return resource.RetryableError(fmt.Errorf("Network ACL rule (%s) not found", d.Id()))