Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spot Fleet Launch Template Support #12732

Merged
merged 67 commits into from
Apr 28, 2020
Merged

Spot Fleet Launch Template Support #12732

merged 67 commits into from
Apr 28, 2020

Commits on Apr 26, 2020

  1. added launch templates and ondemand capacity

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    fb0e0aa View commit details
    Browse the repository at this point in the history

  2. Added tests with incorrect subresource ids

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    077cb40 View commit details
    Browse the repository at this point in the history

  3. Added documentation

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    d5181c8 View commit details
    Browse the repository at this point in the history

  4. added forceNews, ondemand active instance handling on delete and bett… 

    …er resource reading
    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    56a7c2e View commit details
    Browse the repository at this point in the history

  5. Fixed test failure and added better debugging, added tests

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    4ba60ab View commit details
    Browse the repository at this point in the history

  6. remove unnecessary float64 conversion causing lint failure

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    f3d2ec3 View commit details
    Browse the repository at this point in the history

  7. remove commented validatefuncs

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    42d717f View commit details
    Browse the repository at this point in the history

  8. comment customdiff

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    0f4144c View commit details
    Browse the repository at this point in the history

  9. fix commenting and logic of template to config assignment

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    99cca27 View commit details
    Browse the repository at this point in the history

  10. comment nonretryable error

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    785ab9e View commit details
    Browse the repository at this point in the history

  11. clean up commented test

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    2599b36 View commit details
    Browse the repository at this point in the history

  12. attempt to fix documentation as per review request

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    08f3d6c View commit details
    Browse the repository at this point in the history

  13. removed on-demand spot instance feature due to moving to a different PR

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    87fb70b View commit details
    Browse the repository at this point in the history

  14. rename overrideToMap to flattenSpotFleetRequestLaunchTemplateOverrides

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    277770f View commit details
    Browse the repository at this point in the history

  15. remove comment cruft

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    4e25015 View commit details
    Browse the repository at this point in the history

  16. added launch template conflict with launch specification test

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    eca0782 View commit details
    Browse the repository at this point in the history

  17. fixed lint errors, readded somehow missing tests

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    2d31a12 View commit details
    Browse the repository at this point in the history

  18. fix missing tests retry

    @lossanarch @DrFaust92
    lossanarch authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    cc8737d View commit details
    Browse the repository at this point in the history

  19. fmt

    @DrFaust92
    Circle authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    aaea7ca View commit details
    Browse the repository at this point in the history

  20. remove duplicate test

    @DrFaust92
    Circle authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    0d2fe42 View commit details
    Browse the repository at this point in the history

  21. fix arn check regex

    @DrFaust92
    Circle authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    a24cdea View commit details
    Browse the repository at this point in the history

  22. Update website/docs/r/spot_fleet_request.html.markdown 

    Co-Authored-By: Gauthier Wallet <gauthier.wallet@gmail.com>
    @lossanarch @Ninir @DrFaust92
    2 people authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    366d5a0 View commit details
    Browse the repository at this point in the history

  23. Update website/docs/r/spot_fleet_request.html.markdown 

    Co-Authored-By: Gauthier Wallet <gauthier.wallet@gmail.com>
    @lossanarch @Ninir @DrFaust92
    2 people authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    0a9d8f6 View commit details
    Browse the repository at this point in the history

  24. Update website/docs/r/spot_fleet_request.html.markdown 

    Co-Authored-By: Gauthier Wallet <gauthier.wallet@gmail.com>
    @lossanarch @Ninir @DrFaust92
    2 people authored and DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    9e7361b View commit details
    Browse the repository at this point in the history

  25. foramtting changes

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    268f228 View commit details
    Browse the repository at this point in the history

  26. fix config conflict test

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    0e699aa View commit details
    Browse the repository at this point in the history

  27. fix docs lint

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    09b535c View commit details
    Browse the repository at this point in the history

  28. fix code lint

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    9e8a9ee View commit details
    Browse the repository at this point in the history

  29. refactor docs

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    f7706f5 View commit details
    Browse the repository at this point in the history

  30. refactor docs

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    afa407f View commit details
    Browse the repository at this point in the history

  31. remove on demand test, docs and code

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    2b2bf42 View commit details
    Browse the repository at this point in the history

  32. add priority argument 

    fix some launch template tests
    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    a109564 View commit details
    Browse the repository at this point in the history

  33. add priority to docs

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    0221ddc View commit details
    Browse the repository at this point in the history

  34. allows zero value priority

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    a4d1ad9 View commit details
    Browse the repository at this point in the history

  35. add priority and fix test hashes

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    c0550c9 View commit details
    Browse the repository at this point in the history

  36. add disappearing test case

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    aa87abe View commit details
    Browse the repository at this point in the history

  37. Update aws/resource_aws_spot_fleet_request.go 

    Co-Authored-By: Brian Flad <bflad417@gmail.com>
    @DrFaust92 @bflad
    DrFaust92 and bflad committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    2c433eb View commit details
    Browse the repository at this point in the history

  38. Update aws/resource_aws_spot_fleet_request.go 

    Co-Authored-By: Brian Flad <bflad417@gmail.com>
    @DrFaust92 @bflad
    DrFaust92 and bflad committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    035f9ef View commit details
    Browse the repository at this point in the history

  39. Update aws/resource_aws_spot_fleet_request.go 

    Co-Authored-By: Brian Flad <bflad417@gmail.com>
    @DrFaust92 @bflad
    DrFaust92 and bflad committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    47a1cff View commit details
    Browse the repository at this point in the history

  40. rename launch_template_configs to launch_template_config

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    3cc8379 View commit details
    Browse the repository at this point in the history

  41. remove new line

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    856bde5 View commit details
    Browse the repository at this point in the history

  42. remove new lines from tests

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    2814a5f View commit details
    Browse the repository at this point in the history

  43. ar least one of lunch spec or config

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    659e268 View commit details
    Browse the repository at this point in the history

  44. typo in doc

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    24cc585 View commit details
    Browse the repository at this point in the history

  45. remove comment

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    75f648f View commit details
    Browse the repository at this point in the history

  46. add multi config test

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    eed405f View commit details
    Browse the repository at this point in the history

  47. fix multi test

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    ba21702 View commit details
    Browse the repository at this point in the history

  48. fix multi test

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    9c42827 View commit details
    Browse the repository at this point in the history

  49. remove hardcoded ami + instance types 

    remove hash checks
    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    52aa1ce View commit details
    Browse the repository at this point in the history

  50. remove extraneous error var

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    91e4656 View commit details
    Browse the repository at this point in the history

  51. replace ConflictsWith + AtLeastOneOf with ExactlyOneOf

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    d81c177 View commit details
    Browse the repository at this point in the history

  52. flatten launch_template_config

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    c938898 View commit details
    Browse the repository at this point in the history

  53. fix error

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    d727686 View commit details
    Browse the repository at this point in the history

  54. fix flattening launch template config

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    8ad1fcd View commit details
    Browse the repository at this point in the history

  55. cant have duplicate in override

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    cbb1a1d View commit details
    Browse the repository at this point in the history

  56. dont retry for Duplicate: Parameter combination exception

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    061ff7e View commit details
    Browse the repository at this point in the history

  57. changes

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    b1e25cc View commit details
    Browse the repository at this point in the history

  58. change from RetryableError to NonRetryableError for duplicate exception

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    b6e31cf View commit details
    Browse the repository at this point in the history

  59. fix multi test

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    af6885d View commit details
    Browse the repository at this point in the history

  60. format

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    e19d346 View commit details
    Browse the repository at this point in the history

  61. add tags + reuse

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    1396b55 View commit details
    Browse the repository at this point in the history

  62. use rname

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    6cb7fec View commit details
    Browse the repository at this point in the history

  63. use rname

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    3a90972 View commit details
    Browse the repository at this point in the history

  64. consolidate ami usage

    @DrFaust92
    DrFaust92 committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    88e4968 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. resource/aws_spot_fleet_request: Fix minor typo in error message

    @bflad
    bflad committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    4b3ea31 View commit details
    Browse the repository at this point in the history

  2. tests/resource/aws_spot_fleet_request: Remove failing TestAccAWSSpotF… 

    …leetRequest_launchTemplateConflictLaunchSpecification
    @bflad
    bflad committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    618cd5b View commit details
    Browse the repository at this point in the history

  3. tests/resource/aws_spot_fleet_request: Remove extraneous newlines fro… 

    …m GitHub suggested changes
    @bflad
    bflad committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    d98d7d7 View commit details
    Browse the repository at this point in the history