Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Backup Vault: Ability to attach a Vault Access Policy #9425

Closed
estevens88 opened this issue Jul 19, 2019 · 2 comments · Fixed by #16112
Closed

AWS Backup Vault: Ability to attach a Vault Access Policy #9425

estevens88 opened this issue Jul 19, 2019 · 2 comments · Fixed by #16112
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/backup Issues and PRs that pertain to the backup service.
Milestone
v3.16.0

Comments

@estevens88
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Similarly to an identity policy we need a way to attach a resource based policy to a backup vault. This will allow us to lock down our backup vaults so that they are not accidentally deleted.

New or Affected Resource(s)

  • aws_backup_vault_policy

Potential Terraform Configuration

I think something similar to how the SQS policy was implemented is all that we need.
https://www.terraform.io/docs/providers/aws/r/sqs_queue_policy.html
@estevens88 estevens88 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 19, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 19, 2019
@aeschright aeschright added the service/backup Issues and PRs that pertain to the backup service. label Aug 2, 2019
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 8, 2020
@DrFaust92 DrFaust92 mentioned this issue Nov 10, 2020
Merged
@breathingdust breathingdust added this to the v3.16.0 milestone Nov 13, 2020
@ghost
Copy link

ghost commented Nov 18, 2020

This has been released in version 3.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/backup Issues and PRs that pertain to the backup service.
Projects
None yet
Milestone
v3.16.0
Development

Successfully merging a pull request may close this issue.

r/backup_vault_policy - new resource DrFaust92/terraform-provider-aws
4 participants
@aeschright @breathingdust @ewbankkit @estevens88