Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RDS Reserved Instances #8521

Closed
davidcelis opened this issue May 3, 2019 · 12 comments · Fixed by #26025
Closed

Support for RDS Reserved Instances #8521

davidcelis opened this issue May 3, 2019 · 12 comments · Fixed by #26025
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@davidcelis
Copy link
Contributor

davidcelis commented May 3, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Like EC2, Amazon's RDS system also allows the purchase of reserved instances which are used if compatible RDS instances are spun up. It'd be cool if the AWS provider supported the creation of these!

New or Affected Resource(s)

  • aws_rds_reserved_instance

Potential Terraform Configuration

provider "aws" {}

resource "aws_rds_reserved_instance" "my-reservation" {
  offering_id = "438012d3-4052-4cc7-b2e3-8d3372e0e706"
  reservation_id = "optionalCustomReservationID"
  instance_count = 3

  tags = {}
}

References

https://docs.aws.amazon.com/cli/latest/reference/rds/purchase-reserved-db-instances-offering.html

@davidcelis davidcelis added the enhancement Requests to existing resources that expand the functionality or scope. label May 3, 2019
@bflad bflad added the service/rds Issues and PRs that pertain to the rds service. label May 7, 2019
@debu99
Copy link

debu99 commented May 16, 2019

+1

@LouisMaycol
Copy link

Are there any plans when can this be done? Kinda need this too

@joshuaganger
Copy link

Is there actually support for EC2 reserved instances? The only documentation I can find is regarding capacity reservations which is a different concept entirely.

@davidcelis
Copy link
Contributor Author

@joshuaganger Doesn't look like it, though I made no claim that the AWS provider supports EC2 reserved instances; I only said that they exist 😉

@sjobyt
Copy link

sjobyt commented Oct 11, 2019

Would like to see this as well. It would be nice to manage this through code as well.

@RafeKettler
Copy link

This would also be useful for aws_elasticsearch_domain resources as well. Not sure if that warrants a separate ticket, probably not given there is a broader effort to support reserved instances in terraform-provider-aws in the first place.

@jspiro
Copy link

jspiro commented Oct 9, 2020

+1

@johnB96
Copy link

johnB96 commented Jun 13, 2022

+1, devs still want this

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Jun 28, 2022
@YakDriver
Copy link
Member

@tocy1
Copy link

tocy1 commented Sep 19, 2022

+1

@github-actions github-actions bot added this to the v4.35.0 milestone Oct 8, 2022
@github-actions
Copy link

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.