Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_glue_crawler : unable to remove schedule from existing crawler #8401

Closed
romanovna opened this issue Apr 22, 2019 · 3 comments · Fixed by #14792
Closed

aws_glue_crawler : unable to remove schedule from existing crawler #8401

romanovna opened this issue Apr 22, 2019 · 3 comments · Fixed by #14792
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service.
Milestone

Comments

@romanovna
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.11.13

  • provider.archive v1.2.1
  • provider.aws v2.7.0
  • provider.template v2.1.1

Affected Resource(s)

  • aws_glue_crawler

Terraform Configuration Files

resource "aws_glue_crawler" "crawler_eia_atomic" {
  count = "${length(var.stream_names)}"
  database_name = "${aws_glue_catalog_database.database_catalog.name}"
  name = "${var.environment}-${element(var.stream_names, count.index)}-eia-atomic"
  role = "${element(aws_iam_role.role_glue_crawler.*.name, count.index)}"
  table_prefix = "${element(var.stream_names, count.index)}_eia_"
  schedule = "cron(05 8 * * ? *)"
  configuration = <<CONF
  {"Version": 1.0,
    "CrawlerOutput":
        { "Partitions":
            { "AddOrUpdateBehavior": "InheritFromTable" } } }
  CONF
  s3_target {
    path = "s3://${element(aws_s3_bucket.bucket.*.bucket, count.index)}/atomic/"
  }
  schema_change_policy {
    delete_behavior = "DELETE_FROM_DATABASE"
    update_behavior = "UPDATE_IN_DATABASE"
  }
}

Debug Output

Panic Output

Expected Behavior

Removing "schedule" line - erases any existing rules and makes it "run on demand"

Actual Behavior

Crawler's schedule still here. See steps to reproduce below.

Steps to Reproduce

Let's say, I have a crawler which triggers every 8 hours. But I want to remove this schedule and make it "Run on demand".
If I remove or comment out "schedule line" terraform prints something like

module.streams.aws_glue_crawler.crawler_eia_atomic[1]: Modifying... (ID: dev-events-eia-atomic)
  schedule: "cron(05 8 * * ? *)" => ""

But, actually nothing happens on AWS side , I mean - schedule still persists.

Important Factoids

References

  • #0000
@aeschright aeschright added needs-triage Waiting for first response or review from a maintainer. service/glue Issues and PRs that pertain to the glue service. labels Jun 19, 2019
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 31, 2019
@anGie44 anGie44 added this to the v3.4.0 milestone Aug 24, 2020
@anGie44
Copy link
Contributor

anGie44 commented Aug 24, 2020

The fix for this has been merged and will release with v3.4.0 of the AWS Terraform Provider, expected out later this week.

@ghost
Copy link

ghost commented Aug 27, 2020

This has been released in version 3.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants