Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS VPC Network ACL Protocol "all" Docs Wrong #82

Closed
hashibot opened this issue Jun 13, 2017 · 2 comments
Closed

AWS VPC Network ACL Protocol "all" Docs Wrong #82

hashibot opened this issue Jun 13, 2017 · 2 comments
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation.

Comments

@hashibot
Copy link

This issue was originally opened by @tylerFowler as hashicorp/terraform#5226. It was migrated here as part of the provider split. The original body of the issue is below.


The docs specify that in a network ACL rule (for AWS) a protocol value of "-1" is used to specify all protocols however when it's actually applied the tfstate file shows a protocol value of "all" so this rule will always show a change. Writing a rule as follows seems to fix the issue:

resource "aws_network_acl_rule" "all_out" {
  network_acl_id = "${aws_network_acl.some_acl.id}"
  rule_number = 100
  egress = true
  protocol = "all" # <- fixes the problem
  cidr_block = "0.0.0.0/0"
  rule_action = "allow"
  from_port = 0
  to_port = 0
}
@hashibot hashibot added bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. labels Jun 13, 2017
@radeksimko
Copy link
Member

Marking as duplicate of hashicorp/terraform#13012

This was resolved in hashicorp/terraform#13049 which was released as part of 0.9.2 (March 28, 2017). The resource should not show up in the diff if protocol = -1 anymore (I just verified using the example above), so no docs updates are needed.

@radeksimko radeksimko marked this as a duplicate of hashicorp/terraform#13012 Aug 2, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation.
Projects
None yet
Development

No branches or pull requests

2 participants