Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags are not getting created #5207

Closed
ghost opened this issue Jul 16, 2018 · 6 comments
Closed

Tags are not getting created #5207

ghost opened this issue Jul 16, 2018 · 6 comments
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@ghost
Copy link

ghost commented Jul 16, 2018

This issue was originally opened by @vady112 as hashicorp/terraform#18469. It was migrated here as a result of the provider split. The original body of the issue is below.


Terraform Version

Terraform v0.11.7

Terraform Configuration Files

provider "aws" {
  region     = "ap-southeast-1"
}


resource "aws_spot_instance_request" "db-test" {
  ami           = "ami-0669c7103ec3373e3"
  spot_price    = "0.4620"
  instance_type = "c4.2xlarge"
  subnet_id = "subnet-91f3a0f5"
  wait_for_fulfillment = "True"
   tags {
    hostname = "db-test"
  }

}

output "ip" {
  value = "${aws_spot_instance_request.db-test.private_ip}"
}

resource "aws_route53_record" "db-test" {
  zone_id = "Z59ISA70Y4WTX"
  name    = "db-test01.dev.sg1.chsh.in"
  type    = "A"
  ttl     = "300"
  records = ["${aws_spot_instance_request.db-test.private_ip}"]
}

Debug Output

Crash Output

Expected Behavior

Tags should be applied to instances.

Actual Behavior

No tags have been created on instances and there is no error reported.

Steps to Reproduce

  1. terraform init
  2. terraform apply

Additional Context

  ami:                             "" => "ami-0669c7103ec3373e3"
  associate_public_ip_address:     "" => "<computed>"
  availability_zone:               "" => "<computed>"
  ebs_block_device.#:              "" => "<computed>"
  ephemeral_block_device.#:        "" => "<computed>"
  get_password_data:               "" => "false"
  instance_interruption_behaviour: "" => "terminate"
  instance_state:                  "" => "<computed>"
  instance_type:                   "" => "c4.2xlarge"
  ipv6_address_count:              "" => "<computed>"
  ipv6_addresses.#:                "" => "<computed>"
  key_name:                        "" => "<computed>"
  network_interface.#:             "" => "<computed>"
  network_interface_id:            "" => "<computed>"
  password_data:                   "" => "<computed>"
  placement_group:                 "" => "<computed>"
  primary_network_interface_id:    "" => "<computed>"
  private_dns:                     "" => "<computed>"
  private_ip:                      "" => "<computed>"
  public_dns:                      "" => "<computed>"
  public_ip:                       "" => "<computed>"
  root_block_device.#:             "" => "<computed>"
  security_groups.#:               "" => "<computed>"
  source_dest_check:               "" => "true"
  spot_bid_status:                 "" => "<computed>"
  spot_instance_id:                "" => "<computed>"
  spot_price:                      "" => "0.4620"
  spot_request_state:              "" => "<computed>"
  spot_type:                       "" => "persistent"
  subnet_id:                       "" => "subnet-91f3a0f5"
  tags.%:                          "" => "1"
  tags.hostname:                   "" => "db-test"
  tenancy:                         "" => "<computed>"
  valid_from:                      "" => "<computed>"
  valid_until:                     "" => "<computed>"
  vpc_security_group_ids.#:        "" => "<computed>"
  wait_for_fulfillment:            "" => "true"

References

@bflad bflad added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jul 16, 2018
@vady112
Copy link

vady112 commented Jul 25, 2018

Hi, any update on the issue?

@dolftax
Copy link

dolftax commented Jul 27, 2018

@bflad Any update on the same? This is blocking our terraform migration rollout in production.

Thanks.

@bflad
Copy link
Contributor

bflad commented Jul 30, 2018

I marked this as documentation because the top level tags argument (as described in the original issue comment) applies to the Spot Instance Request itself, not any launched instance. The feature enhancement of tagging the launched instance can be found at: #32

@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jul 20, 2020
@ewbankkit
Copy link
Contributor

I will submit a PR to call this out in the documentation.
Closing this as a duplicate of #32.

@ghost
Copy link
Author

ghost commented Sep 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

4 participants