Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_vpn_gateway_attachment: Incorrect error code for missing VPN gateway #4894

Closed
ewbankkit opened this issue Jun 20, 2018 · 3 comments · Fixed by #4895
Closed

r/aws_vpn_gateway_attachment: Incorrect error code for missing VPN gateway #4894

ewbankkit opened this issue Jun 20, 2018 · 3 comments · Fixed by #4895
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone
v1.24.0

Comments

@ewbankkit
Copy link
Contributor

When deleting an aws_vpn_gateway_attachment:

* aws_vpn_gateway_attachment.test2: Error detaching VPN Gateway "vgw-xxxxxxxx" from VPC "vpc-xxxxxxxx": InvalidVpnGatewayID.NotFound: The vpnGateway ID 'vgw-xxxxxxxx' does not exist
	status code: 400, request id: 15974695-8ffc-45e0-82c0-21d3df0d2c49

The VPN gateway attachment code is using an incorrectly capitalized AWS error code for the missing VPN gateway: https://github.com/terraform-providers/terraform-provider-aws/blob/b040e1de45f51432347bef28f8c4dccaeec425c5/aws/resource_aws_vpn_gateway_attachment.go#L133

The correctly capitalized AWS error code is used in the aws_vpn_gateway resource: https://github.com/terraform-providers/terraform-provider-aws/blob/b040e1de45f51432347bef28f8c4dccaeec425c5/aws/resource_aws_vpn_gateway.go#L171
@ewbankkit ewbankkit mentioned this issue Jun 20, 2018
Merged
@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jun 21, 2018
@bflad bflad added this to the v1.24.0 milestone Jun 21, 2018
@bflad
Copy link
Contributor

bflad commented Jun 21, 2018

The fix for this has been merged into master and will release with version 1.24.0 of the AWS provider, very shortly.

@bflad
Copy link
Contributor

bflad commented Jun 25, 2018

This has been released in version 1.24.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
v1.24.0
2 participants
@bflad @ewbankkit