Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_fsx_openzfs_file_system increase SINGLE_AZ_2 max IOPS to 400000 #40359

Conversation

brinnjoyce
Copy link
Contributor

@brinnjoyce brinnjoyce commented Nov 29, 2024

Description

Increases the aws_fsx_openzfs_file_system SINGLE_AZ_2 max valid IOPS to 400000 to match what's supported by AWS and allow the terraform provider to work with larger filesystems which force IOPS to be above the current 350000 limit of the provider.

Relations

Closes #40358

References

Reference for max IOPS https://docs.aws.amazon.com/fsx/latest/OpenZFSGuide/performance.html#zfs-fs-performance

Output from Acceptance Testing

Let me know if I need to run the tests myself and I can try to arrange a sandbox account.

@brinnjoyce brinnjoyce requested a review from a team as a code owner November 29, 2024 00:23
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/fsx Issues and PRs that pertain to the fsx service. needs-triage Waiting for first response or review from a maintainer. labels Nov 29, 2024
@brinnjoyce brinnjoyce changed the title Bump openzfs SINGLE_AZ_2 max IOPS to 400000 r/aws_fsx_openzfs_file_system increase SINGLE_AZ_2 max IOPS to 400000 Nov 29, 2024
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 2, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@brinnjoyce Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 23e0b31 into hashicorp:main Dec 2, 2024
32 checks passed
@github-actions github-actions bot added this to the v5.79.0 milestone Dec 2, 2024
Copy link

github-actions bot commented Dec 3, 2024

This functionality has been released in v5.79.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@brinnjoyce brinnjoyce deleted the b-aws_fsx_openzfs_file_system_iops_increase branch December 6, 2024 00:37
Copy link

github-actions bot commented Jan 5, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/fsx Issues and PRs that pertain to the fsx service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_fsx_openzfs_file_system expected disk_iops_configuration.0.iops range does not allow 400000 IOPS
3 participants