-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sagemaker/domain: Fix ValidationException with AppSecurityGroupMangement #40049
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=sagemaker TESTS=TestAccSageMaker_serial/Domain/rStudioDomainDisabledNetworkUpdate
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMaker_serial/Domain/rStudioDomainDisabledNetworkUpdate' -timeout 360m
2024/11/08 09:33:37 Initializing Terraform AWS Provider...
=== RUN TestAccSageMaker_serial
=== PAUSE TestAccSageMaker_serial
=== CONT TestAccSageMaker_serial
=== RUN TestAccSageMaker_serial/Domain
=== RUN TestAccSageMaker_serial/Domain/rStudioDomainDisabledNetworkUpdate
--- PASS: TestAccSageMaker_serial (432.08s)
--- PASS: TestAccSageMaker_serial/Domain (432.08s)
--- PASS: TestAccSageMaker_serial/Domain/rStudioDomainDisabledNetworkUpdate (432.08s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker 437.660s
This functionality has been released in v5.75.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
It seems like AWS may return something in
app_security_group_management
and then on an update it tries to pass that to AWS when it's not allowed. Note that this is an AWS ValidationException.Relations
Closes #39923
References
Output from Acceptance Testing