-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add encryption_type and kms_key_id params to aws_kenesis_stream data source #39212
feat: Add encryption_type and kms_key_id params to aws_kenesis_stream data source #39212
Conversation
Community NoteVoting for Prioritization
For Submitters
|
7bac59e
to
2a6448b
Compare
2a6448b
to
2960873
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccKinesisStreamDataSource_' PKG=kinesis ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/kinesis/... -v -count 1 -parallel 3 -run=TestAccKinesisStreamDataSource_ -timeout 360m
=== RUN TestAccKinesisStreamDataSource_basic
=== PAUSE TestAccKinesisStreamDataSource_basic
=== RUN TestAccKinesisStreamDataSource_encryption
=== PAUSE TestAccKinesisStreamDataSource_encryption
=== CONT TestAccKinesisStreamDataSource_basic
=== CONT TestAccKinesisStreamDataSource_encryption
--- PASS: TestAccKinesisStreamDataSource_encryption (60.35s)
--- PASS: TestAccKinesisStreamDataSource_basic (93.87s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kinesis 98.806s
@acwwat Thanks for the contribution 🎉 👏. |
Thank you very much for this improvement 🎉 |
This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add two new attributes,
encryption_type
andkms_key_id
, to theaws_kenesis_stream
data source.Relations
Closes #38791
References
Referred to StreamDescriptionSummary for specs.
Output from Acceptance Testing