Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support for Pagination and Parallelism properties for appflow_flow #38714

Closed
nagshrenikbandi opened this issue Aug 6, 2024 · 5 comments · Fixed by #38932
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/appflow Issues and PRs that pertain to the appflow service.
Milestone

Comments

@nagshrenikbandi
Copy link

nagshrenikbandi commented Aug 6, 2024

Description

Support for Pagination and Parallelism properties for Appflow.

Reference: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-appflow-flow-sapodatasourceproperties.html

Affected Resource(s) and/or Data Source(s)

appflow_flow

Potential Terraform Configuration

resource "aws_appflow_flow" "example" {
  name = "example"

  flow_status = "active"

  source_flow_config {
    connector_type = "SAPOData"

    connector_profile_name = "ExampleConnectorName"

    source_connector_properties {
      sapo_data {
        object_path = "https://sap.foo.bar/sap/odata/EXAMPLE"

        pagination_config {
          max_page_size = 10000
        }
        parallelism_config{
           max_parallelism = 3
        }
      }
    }
  }

References

CloudFormation Reference: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-appflow-flow-sapodatasourceproperties.html

Would you like to implement a fix?

None

@nagshrenikbandi nagshrenikbandi added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/appflow Issues and PRs that pertain to the appflow service. label Aug 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 6, 2024
@justinretzolk justinretzolk added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 14, 2024
@mahadzaryab1
Copy link
Contributor

can I work on this issue? I've never contributed to this project and am new to open-source.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.72.0 milestone Oct 15, 2024
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/appflow Issues and PRs that pertain to the appflow service.
Projects
None yet
3 participants