-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_bedrockagent_agent: use configured prepare_agent
value
#37405
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This changes removes logic in the read operation which adjusted the `prepare_agent` argument based on whether or not the agent status was `Prepared`. Now the configured `prepare_agent` value is always used, regardless of the status of the agent. If omitted, the default value of `true` is inherited, meaning that by default agents will always be prepared as part of the create or update operation. The `prepare_agent` value is now also set to `true` when an agent is imported. ```console % make testacc PKG=bedrockagent TESTS=TestAccBedrockAgentAgent_ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgent_' -timeout 360m --- PASS: TestAccBedrockAgentAgent_basic (19.66s) --- PASS: TestAccBedrockAgentAgent_full (19.67s) --- PASS: TestAccBedrockAgentAgent_tags (35.51s) --- PASS: TestAccBedrockAgentAgent_update (37.46s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent 42.493s ```
56dd014
to
9ac5e7d
Compare
This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This changes removes logic in the read operation which adjusted the
prepare_agent
argument based on whether or not the agent status wasPrepared
. Now the configuredprepare_agent
value is always used, regardless of the status of the agent. If omitted, the default value oftrue
is inherited, meaning that by default agents will always be prepared as part of the create or update operation. Theprepare_agent
value is now also set totrue
when an agent is imported.Relations
Closes #37162
References
Output from Acceptance Testing