Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: GitLab support on CodeBuild #36852

Closed
Menahem1 opened this issue Apr 11, 2024 · 9 comments · Fixed by #36880
Closed

[Enhancement]: GitLab support on CodeBuild #36852

Menahem1 opened this issue Apr 11, 2024 · 9 comments · Fixed by #36880
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service.
Milestone

Comments

@Menahem1
Copy link

Menahem1 commented Apr 11, 2024

Description

AWS Codebuild can now support Gitlab as source

Affected Resource(s) and/or Data Source(s)

  • aws_codebuild_project

Potential Terraform Configuration

resource "aws_codebuild_project" "example" {
  source {
    type            = "GITLAB"
    location        = "https://gitlab.com/mitchellh/packer.git"
    git_clone_depth = 1
  }
}

References

https://aws.amazon.com/about-aws/whats-new/2024/03/aws-codebuild-gitlab-gitlab-self-managed/?nc1=h_ls

Would you like to implement a fix?

None

@Menahem1 Menahem1 added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 11, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 11, 2024
@github-actions github-actions bot added the service/codebuild Issues and PRs that pertain to the codebuild service. label Apr 11, 2024
@acwwat
Copy link
Contributor

acwwat commented Apr 12, 2024

@Menahem1 It seems that as of v5.44.0, the provider had the AWS Go SDK v2 dependencies updated in include a version that supports GitLab and GitLab Self Managed. If you are not on this provider version or later, please upgrade and see if setting source type = "GITLAB" works. Appreciate if you could report back on the test results.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 12, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.46.0 milestone Apr 12, 2024
@Menahem1
Copy link
Author

@Menahem1 It seems that as of v5.44.0, the provider had the AWS Go SDK v2 dependencies updated in include a version that supports GitLab and GitLab Self Managed. If you are not on this provider version or later, please upgrade and see if setting source type = "GITLAB" works. Appreciate if you could report back on the test results.

It works, thanks :)

@Menahem1
Copy link
Author

@Menahem1 It seems that as of v5.44.0, the provider had the AWS Go SDK v2 dependencies updated in include a version that supports GitLab and GitLab Self Managed. If you are not on this provider version or later, please upgrade and see if setting source type = "GITLAB" works. Appreciate if you could report back on the test results.

It works, thanks :)

Update : With report_build_status option on GitLab it's not working in my case

@acwwat
Copy link
Contributor

acwwat commented Apr 16, 2024

@Menahem1 It seems that as of v5.44.0, the provider had the AWS Go SDK v2 dependencies updated in include a version that supports GitLab and GitLab Self Managed. If you are not on this provider version or later, please upgrade and see if setting source type = "GITLAB" works. Appreciate if you could report back on the test results.

It works, thanks :)

Update : With report_build_status option on GitLab it's not working in my case

@Menahem1 Could you please open a new issue? I can address the specific case for report_build_status. Thanks.

@Menahem1
Copy link
Author

Menahem1 commented Apr 16, 2024

@acwwat No problem
#36937
Thanks

Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants