Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_cloudfrontkeyvaluestore_key #35793

Closed
ewbankkit opened this issue Feb 13, 2024 · 7 comments · Fixed by #36534
Closed

New Resource: aws_cloudfrontkeyvaluestore_key #35793

ewbankkit opened this issue Feb 13, 2024 · 7 comments · Fixed by #36534
Labels
new-resource Introduces a new resource.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Feb 13, 2024

Following on from the aws_cloudfront_key_value_store resource, add a new resource aws_cloudfrontkeyvaluestore_key to manage an individual key (and associated value) in a store.

resource "aws_cloudfrontkeyvaluestore_key" "example" {
  key   = "k1"
  value = "v1"
}

Relates #34512.
Relates #35663.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit changed the title New Resource: aws_cloudfrontkeyvaluestore_key New Resource: aws_cloudfrontkeyvaluestore_key Feb 13, 2024
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Feb 13, 2024
@womblep
Copy link

womblep commented Mar 8, 2024

@ewbankkit you would need to have a link to the store resource as well

@surenduhan
Copy link

I thought this was being provided with the original PR of key_value_store.

We need multiple things to fully support this feature.

  1. Being able to create and update the resource i.e. KV-Store (key_value_store) . This is merged in 5.37.0
  2. Need modification for cloudfront_function to support arn or id of this key_value_store to be associated with cloudfront_function resource. Otherwise old resource will remove association on update of function code.
  3. This Key-Value pair to be created, modified, and removed. This PR tries to do something, for point 3, but ideal would be to take a JSON or YAML as input to create the list of key values.

With any of the above not being done, this feature is still not useful for cloud automation.

@brittandeyoung
Copy link
Collaborator

I have raised a PR to add the aws_cloudfrontkeyvaluestore_key resource. I also see there is an existing PR to enable attaching a aws_cloudfront_key_value_store to a cloudfront function here #36228 . I plan on taking a look at the pr and see if I can help get it ready for a review

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.43.0 milestone Mar 26, 2024
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants