Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: allow skipFinalBackup for aws_fsx_openzfs_file_system #35319

Closed
brinnjoyce opened this issue Jan 16, 2024 · 3 comments · Fixed by #35320
Closed

[Enhancement]: allow skipFinalBackup for aws_fsx_openzfs_file_system #35319

brinnjoyce opened this issue Jan 16, 2024 · 3 comments · Fixed by #35320
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Milestone

Comments

@brinnjoyce
Copy link
Contributor

brinnjoyce commented Jan 16, 2024

Description

Currently when destroying an aws_fsx_openzfs_file_system resource the API default of creating a final backup is used.
As there is no argument for this in the terraform provider it is not possible to skip this backup. The aws_fsx_windows_file_system for example does have an argument to allow this.

Affected Resource(s) and/or Data Source(s)

  • fsx_openzfs_file_system

Potential Terraform Configuration

resource "aws_fsx_openzfs_file_system" "test" {
  storage_capacity    = 64
  subnet_ids          = [aws_subnet.test1.id]
  deployment_type     = "SINGLE_AZ_1"
  throughput_capacity = 64
  skip_final_backup   = true
}

References

https://docs.aws.amazon.com/cli/latest/reference/fsx/delete-file-system.html#options

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/fsx_windows_file_system#skip_final_backup

Would you like to implement a fix?

Yes

@brinnjoyce brinnjoyce added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 16, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/fsx Issues and PRs that pertain to the fsx service. label Jan 16, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 16, 2024
@brinnjoyce brinnjoyce changed the title [Enhancement]: allow skipFinalBackup for fsx_openzfs_file_system [Enhancement]: allow skipFinalBackup for aws_fsx_openzfs_file_system Jan 16, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 16, 2024
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 24, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants