Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: r/aws_finspace_kx_dataview: tags are not supported #34990

Closed
jar-b opened this issue Dec 19, 2023 · 4 comments · Fixed by #34998
Closed

[Bug]: r/aws_finspace_kx_dataview: tags are not supported #34990

jar-b opened this issue Dec 19, 2023 · 4 comments · Fixed by #34998
Labels
bug Addresses a defect in current functionality. service/finspace Issues and PRs that pertain to the finspace service.
Milestone

Comments

@jar-b
Copy link
Member

jar-b commented Dec 19, 2023

Terraform Core Version

1.6.6

AWS Provider Version

5.31.0

Affected Resource(s)

  • aws_finspace_kx_dataview

Expected Behavior

Creating a dataview with tags set should apply the tags.

Actual Behavior

No tags are applied.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

This branch contains a _tags acceptance test which reproduces the incorrect behavior:
main...f-finspace_kx_dataview-tags

Steps to Reproduce

  1. Checkout the branch above.
  2. Run make testacc PKG=finspace TESTS=TestAccFinSpaceKxDataview_tags

Debug Output

make testacc PKG=finspace TESTS=TestAccFinSpaceKxDataview_tags
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxDataview_tags'  -timeout 360m
=== RUN   TestAccFinSpaceKxDataview_tags
=== PAUSE TestAccFinSpaceKxDataview_tags
=== CONT  TestAccFinSpaceKxDataview_tags
    kx_dataview_test.go:101: Step 1/4 error: Check failed: Check 3/4 error: aws_finspace_kx_dataview.test: Attribute 'tags.%' expected "1", got "0"
--- FAIL: TestAccFinSpaceKxDataview_tags (1064.30s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/finspace   1067.677s

Panic Output

No response

Important Factoids

"Tag-on-create" is also broken for other APIs in this service. The likely solution is to tag after creation using the dataview ARN. ARN is not currently returned in response body of the Create or Describe APIs, so until it is added it will need to be manually composed using the dataview name.

References

Would you like to implement a fix?

None

@jar-b jar-b added the bug Addresses a defect in current functionality. label Dec 19, 2023
@github-actions github-actions bot added the service/finspace Issues and PRs that pertain to the finspace service. label Dec 19, 2023
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@jar-b
Copy link
Member Author

jar-b commented Dec 19, 2023

After testing further, this issue is not due to tag-on-create failing, but the arn attribute being unset. ListTags will always fail when searching using an empty string, resulting in no tags being set on read. PR incoming to address this issue.

Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/finspace Issues and PRs that pertain to the finspace service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant