Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: Added ssoadmin application_access_scope resource #34811

Merged

Conversation

DanielRieske
Copy link
Contributor

Description

This PR will add the aws_ssoadmin_application_access_scope resource that manages AWS Identity Center application access scopes.

Relations

Closes #34762

References

Output from Acceptance Testing

make testacc TESTS=TestAccSSOAdminApplicationAccessScope_ PKG=ssoadmin
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssoadmin/... -v -count 1 -parallel 20 -run='TestAccSSOAdminApplicationAccessScope_'  -timeout 360m
=== RUN   TestAccSSOAdminApplicationAccessScope_basic
=== PAUSE TestAccSSOAdminApplicationAccessScope_basic
=== RUN   TestAccSSOAdminApplicationAccessScope_disappears
=== PAUSE TestAccSSOAdminApplicationAccessScope_disappears
=== CONT  TestAccSSOAdminApplicationAccessScope_basic
=== CONT  TestAccSSOAdminApplicationAccessScope_disappears
--- PASS: TestAccSSOAdminApplicationAccessScope_basic (83.81s)
--- PASS: TestAccSSOAdminApplicationAccessScope_disappears (99.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin   101.952s

Copy link

github-actions bot commented Dec 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Dec 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2023
@DanielRieske DanielRieske changed the title [New Resource]: Added aws_ssoadmin_application_access_scope resource [New Resource]: Added ssoadmin application_access_scope resource Dec 8, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. generators Relates to code generators. labels Dec 8, 2023
@bschaatsbergen bschaatsbergen removed the needs-triage Waiting for first response or review from a maintainer. label Dec 10, 2023
@jar-b jar-b self-assigned this Dec 18, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 18, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=ssoadmin TESTS=TestAccSSOAdminApplicationAccessScope_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssoadmin/... -v -count 1 -parallel 20 -run='TestAccSSOAdminApplicationAccessScope_'  -timeout 360m
=== RUN   TestAccSSOAdminApplicationAccessScope_basic
=== PAUSE TestAccSSOAdminApplicationAccessScope_basic
=== RUN   TestAccSSOAdminApplicationAccessScope_disappears
=== PAUSE TestAccSSOAdminApplicationAccessScope_disappears
=== CONT  TestAccSSOAdminApplicationAccessScope_basic
=== CONT  TestAccSSOAdminApplicationAccessScope_disappears
--- PASS: TestAccSSOAdminApplicationAccessScope_disappears (9.09s)
--- PASS: TestAccSSOAdminApplicationAccessScope_basic (10.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin   13.917s

@jar-b jar-b merged commit 82c0e0b into hashicorp:main Dec 18, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 18, 2023
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_ssoadmin_application_access_scope
3 participants