Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Shield ProactiveEngagement #34667

Merged

Conversation

chasse-code
Copy link

Description

Add support for Shield Proactive Enagagement

Output from Acceptance Testing

make testacc  PKG=shield  TESTS=TestAccShieldProactiveEngagementAssociation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20 -run='TestAccShieldProactiveEngagementAssociation'  -timeout 360m
=== RUN   TestAccShieldProactiveEngagementAssociation_basic
--- PASS: TestAccShieldProactiveEngagementAssociation_basic (102.79s)
=== RUN   TestAccShieldProactiveEngagementAssociation_disabled
--- PASS: TestAccShieldProactiveEngagementAssociation_disabled (108.21s)
=== RUN   TestAccShieldProactiveEngagementAssociation_disappears
--- PASS: TestAccShieldProactiveEngagementAssociation_disappears (108.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/shield     322.697s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/shield Issues and PRs that pertain to the shield service. generators Relates to code generators. labels Nov 30, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Nov 30, 2023
@AdamTylerLynch AdamTylerLynch removed the needs-triage Waiting for first response or review from a maintainer. label Dec 6, 2023
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

I did not run the AccTests. Requesting Hashi to run the tests/linters

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Feb 27, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccShieldProtection_' PKG=shield ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 2  -run=TestAccShieldProtection_ -timeout 360m
=== RUN   TestAccShieldProtection_globalAccelerator
=== PAUSE TestAccShieldProtection_globalAccelerator
=== RUN   TestAccShieldProtection_elasticIPAddress
=== PAUSE TestAccShieldProtection_elasticIPAddress
=== RUN   TestAccShieldProtection_disappears
=== PAUSE TestAccShieldProtection_disappears
=== RUN   TestAccShieldProtection_alb
=== PAUSE TestAccShieldProtection_alb
=== RUN   TestAccShieldProtection_elb
=== PAUSE TestAccShieldProtection_elb
=== RUN   TestAccShieldProtection_cloudFront
=== PAUSE TestAccShieldProtection_cloudFront
=== RUN   TestAccShieldProtection_CloudFront_tags
=== PAUSE TestAccShieldProtection_CloudFront_tags
=== RUN   TestAccShieldProtection_route53
=== PAUSE TestAccShieldProtection_route53
=== CONT  TestAccShieldProtection_globalAccelerator
=== CONT  TestAccShieldProtection_elb
--- PASS: TestAccShieldProtection_elb (68.44s)
=== CONT  TestAccShieldProtection_disappears
--- PASS: TestAccShieldProtection_globalAccelerator (92.58s)
=== CONT  TestAccShieldProtection_alb
--- PASS: TestAccShieldProtection_disappears (34.33s)
=== CONT  TestAccShieldProtection_elasticIPAddress
--- PASS: TestAccShieldProtection_elasticIPAddress (39.24s)
=== CONT  TestAccShieldProtection_CloudFront_tags
--- PASS: TestAccShieldProtection_alb (215.96s)
=== CONT  TestAccShieldProtection_route53
--- PASS: TestAccShieldProtection_route53 (62.69s)
=== CONT  TestAccShieldProtection_cloudFront
--- PASS: TestAccShieldProtection_CloudFront_tags (267.64s)
--- PASS: TestAccShieldProtection_cloudFront (251.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	638.219s
% make testacc TESTARGS='-run=TestAccShield_serial/DRTAccessLogBucketAssociation' PKG=shield
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20  -run=TestAccShield_serial/DRTAccessLogBucketAssociation -timeout 360m
=== RUN   TestAccShield_serial
=== PAUSE TestAccShield_serial
=== CONT  TestAccShield_serial
=== RUN   TestAccShield_serial/DRTAccessLogBucketAssociation
=== RUN   TestAccShield_serial/DRTAccessLogBucketAssociation/basic
=== RUN   TestAccShield_serial/DRTAccessLogBucketAssociation/multibucket
=== RUN   TestAccShield_serial/DRTAccessLogBucketAssociation/disappears
--- PASS: TestAccShield_serial (64.87s)
    --- PASS: TestAccShield_serial/DRTAccessLogBucketAssociation (64.87s)
        --- PASS: TestAccShield_serial/DRTAccessLogBucketAssociation/basic (23.17s)
        --- PASS: TestAccShield_serial/DRTAccessLogBucketAssociation/multibucket (21.48s)
        --- PASS: TestAccShield_serial/DRTAccessLogBucketAssociation/disappears (20.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	71.539s
% make testacc TESTARGS='-run=TestAccShield_serial/DRTAccessRoleARNAssociation' PKG=shield
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20  -run=TestAccShield_serial/DRTAccessRoleARNAssociation -timeout 360m
=== RUN   TestAccShield_serial
=== PAUSE TestAccShield_serial
=== CONT  TestAccShield_serial
=== RUN   TestAccShield_serial/DRTAccessRoleARNAssociation
=== RUN   TestAccShield_serial/DRTAccessRoleARNAssociation/basic
=== RUN   TestAccShield_serial/DRTAccessRoleARNAssociation/disappears
--- PASS: TestAccShield_serial (46.89s)
    --- PASS: TestAccShield_serial/DRTAccessRoleARNAssociation (46.89s)
        --- PASS: TestAccShield_serial/DRTAccessRoleARNAssociation/basic (31.62s)
        --- PASS: TestAccShield_serial/DRTAccessRoleARNAssociation/disappears (15.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	55.060s
% make testacc TESTARGS='-run=TestAccShield_serial/ProactiveEngagement' PKG=shield
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/shield/... -v -count 1 -parallel 20  -run=TestAccShield_serial/ProactiveEngagement -timeout 360m
=== RUN   TestAccShield_serial
=== PAUSE TestAccShield_serial
=== CONT  TestAccShield_serial
=== RUN   TestAccShield_serial/ProactiveEngagement
=== RUN   TestAccShield_serial/ProactiveEngagement/basic
=== RUN   TestAccShield_serial/ProactiveEngagement/disabled
=== RUN   TestAccShield_serial/ProactiveEngagement/disappears
--- PASS: TestAccShield_serial (52.00s)
    --- PASS: TestAccShield_serial/ProactiveEngagement (52.00s)
        --- PASS: TestAccShield_serial/ProactiveEngagement/basic (19.57s)
        --- PASS: TestAccShield_serial/ProactiveEngagement/disabled (16.28s)
        --- PASS: TestAccShield_serial/ProactiveEngagement/disappears (16.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	58.692s

@ewbankkit
Copy link
Contributor

@chasse-code Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b1ff3a0 into hashicorp:main Feb 29, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.39.0 milestone Feb 29, 2024
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/shield Issues and PRs that pertain to the shield service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants