-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_s3control_access_grants_instance: AWS IAM Identity Center integration #34582
r/aws_s3control_access_grants_instance: AWS IAM Identity Center integration #34582
Conversation
…kSSOAdminInstances'.
…ion_arn' attribute.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccS3ControlAccessGrants_serial/^Instance$$' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessGrants_serial/^Instance$ -timeout 360m
=== RUN TestAccS3ControlAccessGrants_serial
=== PAUSE TestAccS3ControlAccessGrants_serial
=== CONT TestAccS3ControlAccessGrants_serial
=== RUN TestAccS3ControlAccessGrants_serial/Instance
=== RUN TestAccS3ControlAccessGrants_serial/Instance/basic
=== RUN TestAccS3ControlAccessGrants_serial/Instance/disappears
=== RUN TestAccS3ControlAccessGrants_serial/Instance/tags
=== RUN TestAccS3ControlAccessGrants_serial/Instance/identityCenter
--- PASS: TestAccS3ControlAccessGrants_serial (234.17s)
--- PASS: TestAccS3ControlAccessGrants_serial/Instance (234.17s)
--- PASS: TestAccS3ControlAccessGrants_serial/Instance/basic (29.29s)
--- PASS: TestAccS3ControlAccessGrants_serial/Instance/disappears (23.77s)
--- PASS: TestAccS3ControlAccessGrants_serial/Instance/tags (73.09s)
--- PASS: TestAccS3ControlAccessGrants_serial/Instance/identityCenter (108.02s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 237.313s
This functionality has been released in v5.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the
identity_center_arn
argument andidentity_center_application_arn
attribute toaws_s3control_access_grants_instance
to support AWS IAM Identity Center integration.Relations
Closes #34578.
Relates #34556.
Output from Acceptance Testing