Fix: aws_verifiedaccess_group policy can't be set when no policy was set initially

[sQu4rks]

Description

Fixes an issue in the aws_verifiedaccess_group where a policy document can't be set on a resource that was created without an attached policy.

• Set PolicyEnabled flag on the ModifyVerifiedAccessGroupPolicyInput to true when detecting a changed policy.
• Added two acceptance tests - one for policy changes and one for setting a policy on a resource that previously didn't have one.

Relations

Closes #34052

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVerifiedAccessGroup_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVerifiedAccessGroup_ -timeout 360m
=== RUN   TestAccVerifiedAccessGroup_basic
=== PAUSE TestAccVerifiedAccessGroup_basic
=== RUN   TestAccVerifiedAccessGroup_disappears
=== PAUSE TestAccVerifiedAccessGroup_disappears
=== RUN   TestAccVerifiedAccessGroup_tags
=== PAUSE TestAccVerifiedAccessGroup_tags
=== RUN   TestAccVerifiedAccessGroup_policy
=== PAUSE TestAccVerifiedAccessGroup_policy
=== RUN   TestAccVerifiedAccessGroup_updatePolicy
=== PAUSE TestAccVerifiedAccessGroup_updatePolicy
=== RUN   TestAccVerifiedAccessGroup_setPolicy
=== PAUSE TestAccVerifiedAccessGroup_setPolicy
=== CONT  TestAccVerifiedAccessGroup_basic
=== CONT  TestAccVerifiedAccessGroup_policy
--- PASS: TestAccVerifiedAccessGroup_policy (26.58s)
=== CONT  TestAccVerifiedAccessGroup_setPolicy
--- PASS: TestAccVerifiedAccessGroup_basic (28.48s)
=== CONT  TestAccVerifiedAccessGroup_tags
--- PASS: TestAccVerifiedAccessGroup_setPolicy (39.41s)
=== CONT  TestAccVerifiedAccessGroup_disappears
--- PASS: TestAccVerifiedAccessGroup_tags (48.96s)
=== CONT  TestAccVerifiedAccessGroup_updatePolicy
--- PASS: TestAccVerifiedAccessGroup_disappears (18.77s)
--- PASS: TestAccVerifiedAccessGroup_updatePolicy (38.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        118.663s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVerifiedAccessGroup_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVerifiedAccessGroup_ -timeout 360m
=== RUN   TestAccVerifiedAccessGroup_basic
=== PAUSE TestAccVerifiedAccessGroup_basic
=== RUN   TestAccVerifiedAccessGroup_disappears
=== PAUSE TestAccVerifiedAccessGroup_disappears
=== RUN   TestAccVerifiedAccessGroup_tags
=== PAUSE TestAccVerifiedAccessGroup_tags
=== RUN   TestAccVerifiedAccessGroup_policy
=== PAUSE TestAccVerifiedAccessGroup_policy
=== RUN   TestAccVerifiedAccessGroup_updatePolicy
=== PAUSE TestAccVerifiedAccessGroup_updatePolicy
=== RUN   TestAccVerifiedAccessGroup_setPolicy
=== PAUSE TestAccVerifiedAccessGroup_setPolicy
=== CONT  TestAccVerifiedAccessGroup_basic
=== CONT  TestAccVerifiedAccessGroup_policy
--- PASS: TestAccVerifiedAccessGroup_basic (29.65s)
=== CONT  TestAccVerifiedAccessGroup_tags
--- PASS: TestAccVerifiedAccessGroup_policy (30.05s)
=== CONT  TestAccVerifiedAccessGroup_disappears
--- PASS: TestAccVerifiedAccessGroup_disappears (25.56s)
=== CONT  TestAccVerifiedAccessGroup_setPolicy
--- PASS: TestAccVerifiedAccessGroup_tags (69.63s)
=== CONT  TestAccVerifiedAccessGroup_updatePolicy
--- PASS: TestAccVerifiedAccessGroup_setPolicy (54.57s)
--- PASS: TestAccVerifiedAccessGroup_updatePolicy (49.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	154.467s

[ewbankkit]

@sQu4rks Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.