-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added open_table_format_input attribute + tests #33274
feat: added open_table_format_input attribute + tests #33274
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @younggawthorpe-nowpensions 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGlueCatalogTable_' PKG=glue ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 2 -run=TestAccGlueCatalogTable_ -timeout 180m
=== RUN TestAccGlueCatalogTable_basic
=== PAUSE TestAccGlueCatalogTable_basic
=== RUN TestAccGlueCatalogTable_columnParameters
=== PAUSE TestAccGlueCatalogTable_columnParameters
=== RUN TestAccGlueCatalogTable_full
=== PAUSE TestAccGlueCatalogTable_full
=== RUN TestAccGlueCatalogTable_Update_addValues
=== PAUSE TestAccGlueCatalogTable_Update_addValues
=== RUN TestAccGlueCatalogTable_Update_replaceValues
=== PAUSE TestAccGlueCatalogTable_Update_replaceValues
=== RUN TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
=== RUN TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
=== RUN TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
=== RUN TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== PAUSE TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
=== RUN TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_schemaReference
=== RUN TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== PAUSE TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
=== RUN TestAccGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccGlueCatalogTable_partitionIndexesSingle
=== RUN TestAccGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccGlueCatalogTable_partitionIndexesMultiple
=== RUN TestAccGlueCatalogTable_Disappears_database
=== PAUSE TestAccGlueCatalogTable_Disappears_database
=== RUN TestAccGlueCatalogTable_targetTable
=== PAUSE TestAccGlueCatalogTable_targetTable
=== RUN TestAccGlueCatalogTable_disappears
=== PAUSE TestAccGlueCatalogTable_disappears
=== RUN TestAccGlueCatalogTable_openTableFormat
=== PAUSE TestAccGlueCatalogTable_openTableFormat
=== CONT TestAccGlueCatalogTable_basic
=== CONT TestAccGlueCatalogTable_StorageDescriptor_schemaReference
--- PASS: TestAccGlueCatalogTable_basic (50.03s)
=== CONT TestAccGlueCatalogTable_Disappears_database
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReference (86.35s)
=== CONT TestAccGlueCatalogTable_openTableFormat
--- PASS: TestAccGlueCatalogTable_Disappears_database (39.84s)
=== CONT TestAccGlueCatalogTable_disappears
--- PASS: TestAccGlueCatalogTable_disappears (43.51s)
=== CONT TestAccGlueCatalogTable_targetTable
--- PASS: TestAccGlueCatalogTable_openTableFormat (55.72s)
=== CONT TestAccGlueCatalogTable_StorageDescriptor_emptyBlock
--- PASS: TestAccGlueCatalogTable_targetTable (49.16s)
=== CONT TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_emptyBlock (40.89s)
=== CONT TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSkewedInfo_emptyBlock (43.42s)
=== CONT TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_updateValues (83.32s)
=== CONT TestAccGlueCatalogTable_Update_addValues
--- PASS: TestAccGlueCatalogTable_StorageDescriptorSerDeInfo_emptyBlock (41.53s)
=== CONT TestAccGlueCatalogTable_Update_replaceValues
--- PASS: TestAccGlueCatalogTable_Update_replaceValues (85.95s)
=== CONT TestAccGlueCatalogTable_full
--- PASS: TestAccGlueCatalogTable_Update_addValues (87.18s)
=== CONT TestAccGlueCatalogTable_partitionIndexesSingle
--- PASS: TestAccGlueCatalogTable_partitionIndexesSingle (50.41s)
=== CONT TestAccGlueCatalogTable_partitionIndexesMultiple
--- PASS: TestAccGlueCatalogTable_full (50.52s)
=== CONT TestAccGlueCatalogTable_columnParameters
--- PASS: TestAccGlueCatalogTable_columnParameters (50.96s)
=== CONT TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN
--- PASS: TestAccGlueCatalogTable_partitionIndexesMultiple (51.23s)
--- PASS: TestAccGlueCatalogTable_StorageDescriptor_schemaReferenceARN (48.75s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 509.500s
@younggawthorpe-nowpensions Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
``Description
This PR adds in support for AWS glue tables open table formats.
Had some issues as the Open format input is not returned as part of the table read and is instead marked as updates to the table parameters, this meant changing some additional code to prevent issues with the state.
Relations
Closes: #33157
References
Output from Acceptance Testing
terraform-provider-aws % make testacc TESTS=TestAccGlueCatalogTable_openTableFormat PKG=glue ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueCatalogTable_openTableFormat' -timeout 180m === RUN TestAccGlueCatalogTable_openTableFormat === PAUSE TestAccGlueCatalogTable_openTableFormat === CONT TestAccGlueCatalogTable_openTableFormat --- PASS: TestAccGlueCatalogTable_openTableFormat (39.21s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 41.707s