Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags: send all old and new tags to updateTags #33226

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Aug 29, 2023

Description

Relations

Closes #33219.
Relates #31941.

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccVPC_ -short' PKG=vpc

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_ -short -timeout 180m
    vpc_test.go:1021: skipping long-running test in short mode
--- SKIP: TestAccVPC_IPAMIPv4BasicNetmask (0.00s)
    vpc_test.go:1048: skipping long-running test in short mode
--- SKIP: TestAccVPC_IPAMIPv4BasicExplicitCIDR (0.00s)
    vpc_test.go:1076: skipping long-running test in short mode
--- SKIP: TestAccVPC_IPAMIPv6 (0.00s)
=== NAME  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
    ec2_availability_zone_data_source_test.go:222: skipping since no Local Zones are available
--- SKIP: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (1.03s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (58.74s)
--- PASS: TestAccVPC_tags_null (58.91s)
--- PASS: TestAccVPC_tags_computed (60.92s)
--- PASS: TestAccVPC_basic (70.45s)
--- PASS: TestAccVPC_bothDNSOptionsSet (79.24s)
--- PASS: TestAccVPC_enableNetworkAddressUsageMetrics (81.38s)
--- PASS: TestAccVPC_disabledDNSSupport (81.60s)
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (103.09s)
--- PASS: TestAccVPC_disappears (43.84s)
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (105.82s)
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (107.46s)
--- PASS: TestAccVPC_updateDNSHostnames (108.57s)
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (108.87s)
--- PASS: TestAccVPC_ignoreTags (115.28s)
--- PASS: TestAccVPC_defaultAndIgnoreTags (116.20s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_moveDuplicateTags (127.61s)
--- PASS: TestAccVPC_DefaultTags_zeroValue (132.03s)
--- PASS: TestAccVPC_tenancy (136.89s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (138.57s)
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (138.57s)
--- PASS: TestAccVPC_DefaultTags_providerOnlyTestAccVPC_DefaultTags_providerOnly (138.85s)
--- PASS: TestAccVPC_tags (104.84s)
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (131.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	195.184s
$ make testacc TESTARGS='-run=TestAccKMSKey_tags\|TestAccKMSKey_ignoreTags' PKG=kms

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20  -run=TestAccKMSKey_tags\|TestAccKMSKey_ignoreTags -timeout 180m
--- PASS: TestAccKMSKey_ignoreTags (74.71s)
--- PASS: TestAccKMSKey_tags (109.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	112.919s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 29, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2023
@johnsonaj johnsonaj added the tags Pertains to resource tagging. label Aug 29, 2023
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. and removed tags Pertains to resource tagging. labels Aug 30, 2023
@ewbankkit ewbankkit added the tags Pertains to resource tagging. label Aug 30, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccKMSKey_updateTagsEmptyValue' PKG=kms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20  -run=TestAccKMSKey_updateTagsEmptyValue -timeout 180m
=== RUN   TestAccKMSKey_updateTagsEmptyValue
=== PAUSE TestAccKMSKey_updateTagsEmptyValue
=== CONT  TestAccKMSKey_updateTagsEmptyValue
--- PASS: TestAccKMSKey_updateTagsEmptyValue (77.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	84.141s

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kms Issues and PRs that pertain to the kms service. and removed size/XS Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. labels Aug 30, 2023
@johnsonaj johnsonaj merged commit 0330a8b into main Aug 30, 2023
34 checks passed
@johnsonaj johnsonaj deleted the b-computed_tags_update branch August 30, 2023 15:31
@github-actions github-actions bot added this to the v5.15.0 milestone Aug 30, 2023
github-actions bot pushed a commit that referenced this pull request Aug 30, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. service/kms Issues and PRs that pertain to the kms service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_kms_key: Updating a tag value to an empty string ("") results in timeout
3 participants