F finspace kx environment nacls

[kavan-aws]

Description

This pull request introduces the option to specify network ACLs during environment creation and updates as part of a transit gateway configuration.

Relations

Relates #31802

References

AWS documentation API reference involving the new feature: https://docs.aws.amazon.com/finspace/latest/management-api/API_TransitGatewayConfiguration.html

Output from Acceptance Testing

% make testacc TESTS=TestAccFinSpaceKxEnvironment_attachmentNetworkAclConfiguration PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 10 -run='TestAccFinSpaceKxEnvironment_attachmentNetworkAclConfiguration'  -timeout 180m
=== RUN   TestAccFinSpaceKxEnvironment_attachmentNetworkAclConfiguration
=== PAUSE TestAccFinSpaceKxEnvironment_attachmentNetworkAclConfiguration
=== CONT  TestAccFinSpaceKxEnvironment_attachmentNetworkAclConfiguration
--- PASS: TestAccFinSpaceKxEnvironment_attachmentNetworkAclConfiguration (2258.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	2286.900s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🚀

% make testacc PKG=finspace TESTS=TestAccFinSpaceKxEnvironment_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxEnvironment_'  -timeout 180m
=== RUN   TestAccFinSpaceKxEnvironment_basic
=== PAUSE TestAccFinSpaceKxEnvironment_basic
=== RUN   TestAccFinSpaceKxEnvironment_disappears
=== PAUSE TestAccFinSpaceKxEnvironment_disappears
=== RUN   TestAccFinSpaceKxEnvironment_updateName
=== PAUSE TestAccFinSpaceKxEnvironment_updateName
=== RUN   TestAccFinSpaceKxEnvironment_description
=== PAUSE TestAccFinSpaceKxEnvironment_description
=== RUN   TestAccFinSpaceKxEnvironment_customDNS
=== PAUSE TestAccFinSpaceKxEnvironment_customDNS
=== RUN   TestAccFinSpaceKxEnvironment_transitGateway
=== PAUSE TestAccFinSpaceKxEnvironment_transitGateway
=== RUN   TestAccFinSpaceKxEnvironment_attachmentNetworkACLConfiguration
=== PAUSE TestAccFinSpaceKxEnvironment_attachmentNetworkACLConfiguration
=== RUN   TestAccFinSpaceKxEnvironment_tags
=== PAUSE TestAccFinSpaceKxEnvironment_tags
=== CONT  TestAccFinSpaceKxEnvironment_basic
=== CONT  TestAccFinSpaceKxEnvironment_customDNS
=== CONT  TestAccFinSpaceKxEnvironment_description
=== CONT  TestAccFinSpaceKxEnvironment_updateName
=== CONT  TestAccFinSpaceKxEnvironment_disappears
=== CONT  TestAccFinSpaceKxEnvironment_attachmentNetworkACLConfiguration
=== CONT  TestAccFinSpaceKxEnvironment_tags
=== CONT  TestAccFinSpaceKxEnvironment_transitGateway
--- PASS: TestAccFinSpaceKxEnvironment_basic (1063.24s)
--- PASS: TestAccFinSpaceKxEnvironment_description (1185.44s)
--- PASS: TestAccFinSpaceKxEnvironment_updateName (1207.15s)
--- PASS: TestAccFinSpaceKxEnvironment_disappears (1211.73s)
--- PASS: TestAccFinSpaceKxEnvironment_tags (1225.83s)
--- PASS: TestAccFinSpaceKxEnvironment_customDNS (1667.83s)
--- PASS: TestAccFinSpaceKxEnvironment_transitGateway (1806.95s)
--- PASS: TestAccFinSpaceKxEnvironment_attachmentNetworkACLConfiguration (2409.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/finspace   2412.750s

[jar-b]

Thanks for your contribution, @kavan-aws! 👏

[github-actions]

This functionality has been released in v5.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.