Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Set all parameters to update aws_quicksight_data_source #33061

Conversation

ss49919201
Copy link
Contributor

Description

Set all parameters to update aws_quicksight_data_source

Relations

Closes #32981

Output from Acceptance Testing

% make testacc PKG=quicksight TESTS=TestAccQuickSightDataSource_name
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDataSource_name'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]
=== RUN   TestAccQuickSightDataSource_name
=== PAUSE TestAccQuickSightDataSource_name
=== CONT  TestAccQuickSightDataSource_name
--- PASS: TestAccQuickSightDataSource_name (39.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 40.866s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/quicksight Issues and PRs that pertain to the quicksight service. labels Aug 17, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 17, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ss49919201 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ss49919201 ss49919201 changed the title Set all parameters to update aws_quicksight_data_source [BugFix] Set all parameters to update aws_quicksight_data_source Aug 17, 2023
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 17, 2023
@jar-b jar-b self-assigned this Nov 10, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 10, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

 make testacc PKG=quicksight TESTS=TestAccQuickSightDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDataSource_'  -timeout 360m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]
=== RUN   TestAccQuickSightDataSource_basic
=== PAUSE TestAccQuickSightDataSource_basic
=== RUN   TestAccQuickSightDataSource_disappears
=== PAUSE TestAccQuickSightDataSource_disappears
=== RUN   TestAccQuickSightDataSource_tags
=== PAUSE TestAccQuickSightDataSource_tags
=== RUN   TestAccQuickSightDataSource_permissions
=== PAUSE TestAccQuickSightDataSource_permissions
=== RUN   TestAccQuickSightDataSource_name
=== PAUSE TestAccQuickSightDataSource_name
=== CONT  TestAccQuickSightDataSource_basic
=== CONT  TestAccQuickSightDataSource_permissions
=== CONT  TestAccQuickSightDataSource_name
=== CONT  TestAccQuickSightDataSource_tags
=== CONT  TestAccQuickSightDataSource_disappears
--- PASS: TestAccQuickSightDataSource_basic (308.91s)
--- PASS: TestAccQuickSightDataSource_disappears (311.19s)
--- PASS: TestAccQuickSightDataSource_name (490.24s)
--- PASS: TestAccQuickSightDataSource_tags (614.43s)
--- PASS: TestAccQuickSightDataSource_permissions (665.25s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 668.438s

@jar-b jar-b merged commit 1afa91e into hashicorp:main Nov 11, 2023
46 checks passed
@jar-b
Copy link
Member

jar-b commented Nov 11, 2023

Thanks for your contribution, @ss49919201! 👍

@github-actions github-actions bot added this to the v5.26.0 milestone Nov 11, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Nov 16, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/quicksight Issues and PRs that pertain to the quicksight service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Failure to update aws_quicksight_data_source.name
3 participants