Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Docs do not specify that auto_rollback is only usable when launch_templates are used #32428

Closed
msmith93 opened this issue Jul 7, 2023 · 4 comments · Fixed by #32429
Closed
Labels
documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Milestone

Comments

@msmith93
Copy link
Contributor

msmith93 commented Jul 7, 2023

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group#auto_rollback

Description

While testing, I noticed that an error is seen when setting auto_rollback on an aws_autoscaling_group resource with launch configuration

Error: starting Auto Scaling Group (canary-aws-eu-central-1-dev-probers-2546c63e1107f566-autoscaling-rolling) instance refresh: ValidationError: The request isn't valid. The AutoRollback parameter cannot be set to true when the DesiredConfiguration parameter is empty. Set AutoRollback to false or specify a desired configuration and try again.
│ 	status code: 400, request id: b8d2600b-bd0a-4bfc-a7a2-f7975e1cbb6b

A similar error was reported here: #29830

The bug has been fixed for ASGs backed by launch templates: #31715

But, based on my testing, the error still seems to exist when using launch configurations. Since launch configurations are deprecated, it doesn't make sense to fix this, but it should be clear in the documentation

References

#29830
#31715

Would you like to implement a fix?

Yes

@msmith93 msmith93 added documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@msmith93
Copy link
Contributor Author

msmith93 commented Jul 7, 2023

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 12, 2023
@ewbankkit ewbankkit added the service/autoscaling Issues and PRs that pertain to the autoscaling service. label Jul 20, 2023
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 20, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants