Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iops not undefinable on an aws_ebs_volume violates standards #3239

Open
gtmtech opened this issue Feb 2, 2018 · 3 comments
Open

iops not undefinable on an aws_ebs_volume violates standards #3239

gtmtech opened this issue Feb 2, 2018 · 3 comments
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.

Comments

@gtmtech
Copy link

gtmtech commented Feb 2, 2018

Terraform 0.11.1

mitchellh 's comment on hashicorp/terraform#5471 says that resources must interpret a zero value to be undefined.

iops on an aws_ebs_volume when set to "" says:

Error: module.server.aws_ebs_volume.server_disk2: iops: cannot parse '' as int: strconv.ParseInt: parsing "": invalid syntax

For this reason it is currently impossible to write a module for an aws_ebs_volume which can parameterise whether iops are included or not.

@gtmtech gtmtech changed the title iops not undefinable on an aws_instance violates standards iops not undefinable on an aws_ebs_volume violates standards Feb 2, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 6, 2018
@matthiasr
Copy link
Contributor

is the empty string the zero value for integers?

@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Apr 25, 2021
@matthiasr
Copy link
Contributor

I believe this can be closed. At least as of Terraform 0.14, and with provider 3.x, defaulting the variable to null does the right thing.

@ghost ghost removed the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

No branches or pull requests

3 participants