Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct list of forbidden ids #32352

Merged
merged 4 commits into from
Jul 3, 2023

Conversation

waldiTM
Copy link

@waldiTM waldiTM commented Jul 3, 2023

Description

The provider checked if forbidden account ids have been set, but used the (empty) list of allowed account ids. Just use the correct list of ids.

The provider checked if forbidden account ids have been set, but used
the (empty) list of allowed account ids.  Just use the correct list of
ids.
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 3, 2023
@waldiTM waldiTM marked this pull request as ready for review July 3, 2023 17:13
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 3, 2023
@github-actions github-actions bot added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jul 3, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Validated:

Before

% terraform plan                                     

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.

After

% terraform plan

│ Error: AWS account ID not allowed: 123456789012

│   with provider["registry.terraform.io/hashicorp/aws"],
│   on main.tf line 5, in provider "aws":
│    5: provider "aws" {

@ewbankkit
Copy link
Contributor

@waldiTM Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ae723c0 into hashicorp:main Jul 3, 2023
@github-actions github-actions bot added this to the v5.7.0 milestone Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. client-connections Pertains to the AWS Client and service connections. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants