Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Prevent resource recreation if tags or tags_all change #32297

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 30, 2023

Description

Reverts the change made in #32250 to share tags (and tags_all) schema objects.
Somewhere the ForceNew flag is being set and affecting all resources that use tagging.

Relations

Closes #32296.

References

Output from Acceptance Testing

Before

% make testacc TESTARGS='-run=TestAccVPC_tags$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_tags$ -timeout 180m
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== CONT  TestAccVPC_tags
    vpc_test.go:97: Step 3/4 error: Check failed: Check 2/5 error: VPC IDs are not equal
--- FAIL: TestAccVPC_tags (38.01s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	43.766s
FAIL
make: *** [testacc] Error 1

After

% make testacc TESTARGS='-run=TestAccVPC_tags$$' PKG=ec2                     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_tags$ -timeout 180m
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== CONT  TestAccVPC_tags
--- PASS: TestAccVPC_tags (59.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	65.069s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. tags Pertains to resource tagging. service/vpc Issues and PRs that pertain to the vpc service. size/S Managed by automation to categorize the size of a PR. labels Jun 30, 2023
@ewbankkit ewbankkit added this to the v5.6.1 milestone Jun 30, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccVPC_tags$$' PKG=ec2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_tags$ -timeout 180m
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== CONT  TestAccVPC_tags
--- PASS: TestAccVPC_tags (46.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	49.648s

@ewbankkit ewbankkit merged commit 326b728 into main Jun 30, 2023
@ewbankkit ewbankkit deleted the b-tags-ForceNew branch June 30, 2023 01:56
github-actions bot pushed a commit that referenced this pull request Jun 30, 2023
@github-actions
Copy link

This functionality has been released in v5.6.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. service/vpc Issues and PRs that pertain to the vpc service. size/S Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Terraform Provider v5.6.0 causes Load Balancers recreate when tags change
2 participants