Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: step function alias and versioning #32176

Merged
merged 20 commits into from
Jun 23, 2023

Conversation

sasidhar-aws
Copy link
Contributor

@sasidhar-aws sasidhar-aws commented Jun 22, 2023

Description

Add support for Step function alias and versioning

Relations

Closes #32175.
Closes #32190.

Requires AWS SDK for Go v1.44.288: #32183.

References

https://aws.amazon.com/blogs/compute/deploying-state-machines-incrementally-with-versions-and-aliases-in-aws-step-functions/

Output from Acceptance Testing

make testacc TESTS=TestAccSFNAlias PKG=sfn  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 20 -run='TestAccSFNAlias'  -timeout 180m
=== RUN   TestAccSFNAliasDataSource_basic
=== PAUSE TestAccSFNAliasDataSource_basic
=== RUN   TestAccSFNAlias_basic
=== PAUSE TestAccSFNAlias_basic
=== RUN   TestAccSFNAlias_disappears
=== PAUSE TestAccSFNAlias_disappears
=== CONT  TestAccSFNAliasDataSource_basic
=== CONT  TestAccSFNAlias_basic
=== CONT  TestAccSFNAlias_disappears
--- PASS: TestAccSFNAlias_basic (105.57s)
--- PASS: TestAccSFNAlias_disappears (110.68s)
--- PASS: TestAccSFNAliasDataSource_basic (124.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	129.824s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/sfn Issues and PRs that pertain to the sfn service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jun 22, 2023
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 23, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSFN' PKG=sfn ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 2  -run=TestAccSFN -timeout 180m
=== RUN   TestAccSFNActivityDataSource_basic
=== PAUSE TestAccSFNActivityDataSource_basic
=== RUN   TestAccSFNActivity_basic
=== PAUSE TestAccSFNActivity_basic
=== RUN   TestAccSFNActivity_disappears
=== PAUSE TestAccSFNActivity_disappears
=== RUN   TestAccSFNActivity_tags
=== PAUSE TestAccSFNActivity_tags
=== RUN   TestAccSFNAliasDataSource_basic
=== PAUSE TestAccSFNAliasDataSource_basic
=== RUN   TestAccSFNAlias_basic
=== PAUSE TestAccSFNAlias_basic
=== RUN   TestAccSFNAlias_disappears
=== PAUSE TestAccSFNAlias_disappears
=== RUN   TestAccSFNStateMachineDataSource_basic
=== PAUSE TestAccSFNStateMachineDataSource_basic
=== RUN   TestAccSFNStateMachine_createUpdate
=== PAUSE TestAccSFNStateMachine_createUpdate
=== RUN   TestAccSFNStateMachine_expressUpdate
=== PAUSE TestAccSFNStateMachine_expressUpdate
=== RUN   TestAccSFNStateMachine_standardUpdate
=== PAUSE TestAccSFNStateMachine_standardUpdate
=== RUN   TestAccSFNStateMachine_nameGenerated
=== PAUSE TestAccSFNStateMachine_nameGenerated
=== RUN   TestAccSFNStateMachine_namePrefix
=== PAUSE TestAccSFNStateMachine_namePrefix
=== RUN   TestAccSFNStateMachine_publish
=== PAUSE TestAccSFNStateMachine_publish
=== RUN   TestAccSFNStateMachine_tags
=== PAUSE TestAccSFNStateMachine_tags
=== RUN   TestAccSFNStateMachine_tracing
=== PAUSE TestAccSFNStateMachine_tracing
=== RUN   TestAccSFNStateMachine_disappears
=== PAUSE TestAccSFNStateMachine_disappears
=== RUN   TestAccSFNStateMachine_expressLogging
=== PAUSE TestAccSFNStateMachine_expressLogging
=== RUN   TestAccSFNStateMachineVersionsDataSource_basic
=== PAUSE TestAccSFNStateMachineVersionsDataSource_basic
=== CONT  TestAccSFNActivityDataSource_basic
=== CONT  TestAccSFNStateMachine_standardUpdate
--- PASS: TestAccSFNActivityDataSource_basic (21.90s)
=== CONT  TestAccSFNStateMachine_tracing
--- PASS: TestAccSFNStateMachine_standardUpdate (98.40s)
=== CONT  TestAccSFNAlias_basic
--- PASS: TestAccSFNStateMachine_tracing (150.82s)
=== CONT  TestAccSFNStateMachineVersionsDataSource_basic
--- PASS: TestAccSFNAlias_basic (90.43s)
=== CONT  TestAccSFNStateMachine_publish
--- PASS: TestAccSFNStateMachineVersionsDataSource_basic (77.80s)
=== CONT  TestAccSFNStateMachine_expressLogging
--- PASS: TestAccSFNStateMachine_publish (114.30s)
=== CONT  TestAccSFNStateMachine_disappears
--- PASS: TestAccSFNStateMachine_expressLogging (113.71s)
=== CONT  TestAccSFNStateMachine_namePrefix
--- PASS: TestAccSFNStateMachine_disappears (112.16s)
=== CONT  TestAccSFNStateMachine_nameGenerated
--- PASS: TestAccSFNStateMachine_namePrefix (93.98s)
=== CONT  TestAccSFNActivity_tags
--- PASS: TestAccSFNStateMachine_nameGenerated (161.41s)
=== CONT  TestAccSFNAliasDataSource_basic
--- PASS: TestAccSFNActivity_tags (144.22s)
=== CONT  TestAccSFNStateMachine_tags
--- PASS: TestAccSFNAliasDataSource_basic (96.11s)
=== CONT  TestAccSFNStateMachine_createUpdate
--- PASS: TestAccSFNStateMachine_tags (202.61s)
=== CONT  TestAccSFNStateMachine_expressUpdate
--- PASS: TestAccSFNStateMachine_createUpdate (159.86s)
=== CONT  TestAccSFNActivity_disappears
--- PASS: TestAccSFNActivity_disappears (20.28s)
=== CONT  TestAccSFNActivity_basic
--- PASS: TestAccSFNActivity_basic (66.38s)
=== CONT  TestAccSFNStateMachineDataSource_basic
--- PASS: TestAccSFNStateMachine_expressUpdate (148.80s)
=== CONT  TestAccSFNAlias_disappears
--- PASS: TestAccSFNStateMachineDataSource_basic (135.14s)
--- PASS: TestAccSFNAlias_disappears (135.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	1095.097s

@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Jun 23, 2023
@nam054 nam054 merged commit 8aea8f1 into hashicorp:main Jun 23, 2023
@github-actions github-actions bot added this to the v5.6.0 milestone Jun 23, 2023
@github-actions
Copy link

This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. new-resource Introduces a new resource. partner Contribution from a partner. service/sfn Issues and PRs that pertain to the sfn service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Step Functions Aliases AWS Step Functions Versions and Aliases
4 participants