Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_signer_signing_profile support for new platform_id for container signing with notation #32017

Closed
polarctos opened this issue Jun 15, 2023 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/signer Issues and PRs that pertain to the signer service.

Comments

@polarctos
Copy link

Description

The AWS Signer service now also allows to sign container images.

For this a new platform_id was introduced, namely Notation-OCI-SHA384-ECDSA

Currently aws_signer_signing_profile only allows the platform_id for Lambda:

ValidateFunc: validation.StringInSlice([]string{
"AWSLambda-SHA384-ECDSA"},

Suggested fix, add the new Notation-OCI-SHA384-ECDSA value to the validation:

 ValidateFunc: validation.StringInSlice([]string{ 
 	"AWSLambda-SHA384-ECDSA", "Notation-OCI-SHA384-ECDSA"}, 

These two are currently exposed via the AWS Console:

API name Display name
AWSLambda-SHA384-ECDSA AWS Lambda
Notation-OCI-SHA384-ECDSA Notation for container registries

https://docs.aws.amazon.com/signer/latest/developerguide/console-profile.html

Affected Resource(s) and/or Data Source(s)

  • aws_signer_signing_profile

Potential Terraform Configuration

resource "aws_signer_signing_profile" "notation_test" {
  platform_id = "Notation-OCI-SHA384-ECDSA"
  name        = "notation_test"
}

References

Announcement and docs:

Original AWS Signer resources introduction, including the validation:

Would you like to implement a fix?

No

@polarctos polarctos added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jun 15, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/signer Issues and PRs that pertain to the signer service. label Jun 15, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 15, 2023
@breathingdust breathingdust added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 25, 2023
@johnsonaj
Copy link
Contributor

johnsonaj commented Jul 25, 2023

Feature has been merged in #32414. Was released in v.5.9.0

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/signer Issues and PRs that pertain to the signer service.
Projects
None yet
Development

No branches or pull requests

4 participants