Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add additional parameters for aws_opensearchserverless_collection resource #31939

Closed
balaji-punniyakodi opened this issue Jun 14, 2023 · 5 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service.

Comments

@balaji-punniyakodi
Copy link

Description

Regarding #31091

Hi Team,

I can see you have recently created aws_opensearchserverless_collection resource https://github.com/hashicorp/terraform-provider-aws/blob/main/website/docs/r/opensearchserverless_collection.html.markdown however I dont see the parameter to specify the KMS key, network settings (Public or private with VPCE endpoints) from terraform and resource type.

resource types
kmskey
networksettings

Let us know if you have any further questions.

Affected Resource(s) and/or Data Source(s)

aws_opensearchserverless_collection

Potential Terraform Configuration

No response

References

review #31091 and https://github.com/hashicorp/terraform-provider-aws/blob/main/website/docs/r/opensearchserverless_collection.html.markdown

Would you like to implement a fix?

Yes

@balaji-punniyakodi balaji-punniyakodi added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jun 14, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@balaji-punniyakodi balaji-punniyakodi changed the title [Enhancement]: How to specify additional parameters for opensearchserverless_collection [Enhancement]: Add additional parameters for aws_opensearchserverless_collection resource Jun 14, 2023
@mattburgess
Copy link
Collaborator

mattburgess commented Jun 14, 2023

https://github.com/hashicorp/terraform-provider-aws/pulls?q=is%3Aopen+is%3Apr+label%3Aservice%2Fopensearchserverless shows that the VPC Endpoint resource is still in the queue to be reviewed. Given the recent activity around the OpenSearch serverless resources, I'm quite hopeful it should be looked at quite soon. #28467 is the tracking bug for that resource.

For the Encryption section you see in the console screenshot above, you'll want to use the opensearchserverless_security_policy resource.

@justinretzolk justinretzolk added service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 14, 2023
@joshjluo
Copy link
Contributor

@balaji-punniyakodi As @mattburgess mentioned, I believe all of the screenshots you have provided can be addressed by using the aws_opensearchserverless_security_policy resource to create encryption and network policies applicable to a collection. #32404 was just merged to provide more examples to do what you mention (e.g. specify your own KMS key, configure public access and VPCE access) as well.

@justinretzolk
Copy link
Member

With the above notes, marking this as resolved. If additional functionality is desired, please open a new issue with the requisite details.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service.
Projects
None yet
Development

No branches or pull requests

4 participants